Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: add new tool categories - api and editor #1155

Merged
merged 4 commits into from
Dec 13, 2022

Conversation

magicmatatjahu
Copy link
Member

Description

Add new categories to the tools: editor and api.

cc @derberg

@netlify
Copy link

netlify bot commented Dec 12, 2022

Deploy Preview for asyncapi-website ready!

Built without sensitive environment variables

Name Link
🔨 Latest commit d89be16
🔍 Latest deploy log https://app.netlify.com/sites/asyncapi-website/deploys/639875a48640a20009bb4d78
😎 Deploy Preview https://deploy-preview-1155--asyncapi-website.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@github-actions
Copy link

github-actions bot commented Dec 12, 2022

⚡️ Lighthouse report for the changes in this PR:

Category Score
🟠 Performance 58
🟠 Accessibility 88
🟢 Best practices 100
🟢 SEO 100
🔴 PWA 30

Lighthouse ran on https://deploy-preview-1155--asyncapi-website.netlify.app/

Copy link
Member

@derberg derberg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you add these also as empty entries in manual-tools file. This is how it works at the moment with MVP. This way people that still want to add their tools to website manually, have it easier as all categories are there already

cc @akshatnema

scripts/tools/categorylist.js Outdated Show resolved Hide resolved
@magicmatatjahu
Copy link
Member Author

@derberg Done.

@magicmatatjahu
Copy link
Member Author

/rtm

@asyncapi-bot asyncapi-bot merged commit 59213f1 into asyncapi:master Dec 13, 2022
@magicmatatjahu magicmatatjahu deleted the chore/add-new-categories branch December 13, 2022 13:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants