-
-
Notifications
You must be signed in to change notification settings - Fork 765
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: community events page #1120
feat: community events page #1120
Conversation
✅ Deploy Preview for asyncapi-website ready!Built without sensitive environment variables
To edit notification comments on pull requests, go to your Netlify site settings. |
Please specify the scope of the review and plan for the release because currently you have there stuff without backend:
|
What do you mean by no scheduling in place?
I feel it is needed for the first iteration because i see it as a way to promote all the AsyncaAPI live and recorded events. Unless you feel otherwise |
I'm already working on the backend tho |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey @AceTheCreator, it's a beautiful implementation and work done by you. Here are some of the concerns I want to raise:
While viewing the Upcoming
section, if none of the videos comes up in the section, it should show a message saying "No Upcoming events scheduled".
Also, I think the heading More Events
is quite small as compared to the buttons section you made beside it.
And a kind request, if you are using Prettier in your IDE by default, please disable it or use normal Javascript and Typescript based formatted available in VS code.
--- | ||
title: 'AsyncAPI Community Call' | ||
type: COMMUNITY CALL | ||
description: 'Join us for our upcoming community call to see what’s on our roadmap, early feature demos and product updates from our engineering team. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
description: 'Join us for our upcoming community call to see what’s on our roadmap, early feature demos and product updates from our engineering team. | |
description: 'Join our upcoming community call to discuss our roadmap, feature demos, engineering updates, and more.' |
It's not really a product, right? it's OSS :D
and similarly, not really a team 😄, it's a community with engineering contributors
date: 2022-10-04T06:00:00+01:00 | ||
--- | ||
|
||
Join us for our upcoming community call to see what’s on our roadmap, early feature demos and product updates from our engineering team. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Join us for our upcoming community call to see what’s on our roadmap, early feature demos and product updates from our engineering team. | |
Join our upcoming community call to discuss our roadmap, feature demos, engineering updates, and more. |
|
||
Join us for our upcoming community call to see what’s on our roadmap, early feature demos and product updates from our engineering team. | ||
|
||
### What you will learn |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
### What you will learn |
hmm nope, this header doesn't work... i'd rather remove it unless you have a specific goal for a new section there
pages/community/events/conference.md
Outdated
--- | ||
title: 'UX Conference' | ||
type: CONFERENCE | ||
description: 'Join us for our upcoming community call to see what’s on our roadmap, early feature demos and product updates from our engineering team. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
description: 'Join us for our upcoming community call to see what’s on our roadmap, early feature demos and product updates from our engineering team. | |
description: 'Join our upcoming community call to discuss our roadmap, feature demos, engineering updates, and more.' |
pages/community/events/conference.md
Outdated
@@ -0,0 +1,9 @@ | |||
--- | |||
title: 'UX Conference' |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
title: 'UX Conference' | |
title: 'AsyncAPI Conference' |
are we really going to feature any UX conferences any time soon? 🧐 I guess I think it seems more realistic to name an event we for sure will want to show, like the AsyncAPI conference
pages/community/events/index.js
Outdated
<div className="mt-10 sm:mt-28"> | ||
<div className="w-full sm:w-9/12"> | ||
<h1 className="font-semibold text-3xl lg:text-7xl leading-tight md:text-4xl"> | ||
Join a AsyncAPI event, from anywhere in the world. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Join a AsyncAPI event, from anywhere in the world. | |
Join an AsyncAPI event from anywhere in the world. |
pages/community/events/index.js
Outdated
<div className="text-white w-full sm:w-[50%] p-5 flex flex-col items-center justify-center h-full"> | ||
<div> | ||
<Heading level="h2" typeStyle="heading-md-semibold"> | ||
Schedule an appointment with any of the Technical steering |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Schedule an appointment with any of the Technical steering | |
Start a discussion with Technical Steering Committee members |
what do you think about this? I think this is more accurate
pages/community/events/index.js
Outdated
</Heading> | ||
<Button | ||
className="block md:inline-block focus:outline-none mt-10 bg-black text-center sm:text-left" | ||
text="Schedule a call" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
text="Schedule a call" | |
text="Create TSC discussion " |
pages/community/events/webinar.md
Outdated
--- | ||
title: 'GraphQL to Simplify Data Access for Cloud Native' | ||
type: WEBINAR | ||
description: 'In this webinar, we’ll look at the emerging role of GraphQL as the unifying query language for federated resources in the modern, cloud-native environment. Between SDKs, REST endpoints, secondary GraphQL schemas. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
description: 'In this webinar, we’ll look at the emerging role of GraphQL as the unifying query language for federated resources in the modern, cloud-native environment. Between SDKs, REST endpoints, secondary GraphQL schemas. | |
description: 'In this webinar, we’ll look at the emerging role of GraphQL as the unifying query language for federated resources in the modern, cloud-native environment.' |
do we actually host webinars? it seems to me we host streams, not webinars.... why not have a streams.md
file instead of this current webinar one? 🤔
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@alequetzalli thanks for the review, concerning the list of events, I'm getting rid of them cuz I'm only using em for the sake of view
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looking forward to your replies to my questions, genuinely wanted to learn more about what you're goals are here so that I can provide useful feedback 😄
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🙌🏽
Co-authored-by: Akshat Nema <76521428+akshatnema@users.noreply.github.com>
2bdb2d6
One last review @akshatnema @derberg @alequetzalli |
@AceTheCreator Why the workflow is failing in your PR regarding the links failure? |
No clue, but it's not required I guess |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Approving this PR but I still have many queries regarding the implementation. We will Improve this in the upcoming PRs.
/rtm |
Sorry, what implementation? |
Sorry, removing |
Like I didn't check the code changes thoroughly, not have looked into your implementation very much. Just made some reviews from the Netlify URL 😅. So, it may happen that I'll have some doubts in my mind that why it is implemented in this way 😄. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🚢
/rtm |
Community events page design.
Link to preview https://deploy-preview-1120--asyncapi-website.netlify.app/community/events