Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: community events page #1120

Merged
merged 89 commits into from
Feb 3, 2023
Merged

feat: community events page #1120

merged 89 commits into from
Feb 3, 2023

Conversation

AceTheCreator
Copy link
Member

@AceTheCreator AceTheCreator commented Nov 21, 2022

@netlify
Copy link

netlify bot commented Nov 21, 2022

Deploy Preview for asyncapi-website ready!

Built without sensitive environment variables

Name Link
🔨 Latest commit 8d296ce
🔍 Latest deploy log https://app.netlify.com/sites/asyncapi-website/deploys/63da64b219ce400008933439
😎 Deploy Preview https://deploy-preview-1120--asyncapi-website.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@derberg
Copy link
Member

derberg commented Nov 24, 2022

Please specify the scope of the review and plan for the release because currently you have there stuff without backend:

  • no scheduling in place. So should we review or should that be just commented out and not visible? Imho this is something that can be added later after merging community to master
  • much more sophisticated list of events that is not yet implemented. Just like with previous point, is it needed for first iteration? as backed implementation will take some time really

@AceTheCreator
Copy link
Member Author

Please specify the scope of the review and plan for the release because currently you have there stuff without backend:

  • no scheduling in place. So should we review or should that be just commented out and not visible? Imho this is something that can be added later after merging community to master

What do you mean by no scheduling in place?

  • much more sophisticated list of events that is not yet implemented. Just like with previous point, is it needed for first iteration? as backed implementation will take some time really

I feel it is needed for the first iteration because i see it as a way to promote all the AsyncaAPI live and recorded events. Unless you feel otherwise

@AceTheCreator
Copy link
Member Author

Please specify the scope of the review and plan for the release because currently you have there stuff without backend:

  • no scheduling in place. So should we review or should that be just commented out and not visible? Imho this is something that can be added later after merging community to master

What do you mean by no scheduling in place?

  • much more sophisticated list of events that is not yet implemented. Just like with previous point, is it needed for first iteration? as backed implementation will take some time really

I feel it is needed for the first iteration because i see it as a way to promote all the AsyncaAPI live and recorded events. Unless you feel otherwise

I'm already working on the backend tho

Copy link
Member

@akshatnema akshatnema left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @AceTheCreator, it's a beautiful implementation and work done by you. Here are some of the concerns I want to raise:

image

While viewing the Upcoming section, if none of the videos comes up in the section, it should show a message saying "No Upcoming events scheduled".

Also, I think the heading More Events is quite small as compared to the buttons section you made beside it.

And a kind request, if you are using Prettier in your IDE by default, please disable it or use normal Javascript and Typescript based formatted available in VS code.

---
title: 'AsyncAPI Community Call'
type: COMMUNITY CALL
description: 'Join us for our upcoming community call to see what’s on our roadmap, early feature demos and product updates from our engineering team.
Copy link
Member

@quetzalliwrites quetzalliwrites Dec 10, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
description: 'Join us for our upcoming community call to see what’s on our roadmap, early feature demos and product updates from our engineering team.
description: 'Join our upcoming community call to discuss our roadmap, feature demos, engineering updates, and more.'

It's not really a product, right? it's OSS :D

and similarly, not really a team 😄, it's a community with engineering contributors

date: 2022-10-04T06:00:00+01:00
---

Join us for our upcoming community call to see what’s on our roadmap, early feature demos and product updates from our engineering team.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
Join us for our upcoming community call to see what’s on our roadmap, early feature demos and product updates from our engineering team.
Join our upcoming community call to discuss our roadmap, feature demos, engineering updates, and more.


Join us for our upcoming community call to see what’s on our roadmap, early feature demos and product updates from our engineering team.

### What you will learn
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
### What you will learn

hmm nope, this header doesn't work... i'd rather remove it unless you have a specific goal for a new section there

---
title: 'UX Conference'
type: CONFERENCE
description: 'Join us for our upcoming community call to see what’s on our roadmap, early feature demos and product updates from our engineering team.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
description: 'Join us for our upcoming community call to see what’s on our roadmap, early feature demos and product updates from our engineering team.
description: 'Join our upcoming community call to discuss our roadmap, feature demos, engineering updates, and more.'

@@ -0,0 +1,9 @@
---
title: 'UX Conference'
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
title: 'UX Conference'
title: 'AsyncAPI Conference'

are we really going to feature any UX conferences any time soon? 🧐 I guess I think it seems more realistic to name an event we for sure will want to show, like the AsyncAPI conference

<div className="mt-10 sm:mt-28">
<div className="w-full sm:w-9/12">
<h1 className="font-semibold text-3xl lg:text-7xl leading-tight md:text-4xl">
Join a AsyncAPI event, from anywhere in the world.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
Join a AsyncAPI event, from anywhere in the world.
Join an AsyncAPI event from anywhere in the world.

<div className="text-white w-full sm:w-[50%] p-5 flex flex-col items-center justify-center h-full">
<div>
<Heading level="h2" typeStyle="heading-md-semibold">
Schedule an appointment with any of the Technical steering
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
Schedule an appointment with any of the Technical steering
Start a discussion with Technical Steering Committee members

what do you think about this? I think this is more accurate

</Heading>
<Button
className="block md:inline-block focus:outline-none mt-10 bg-black text-center sm:text-left"
text="Schedule a call"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
text="Schedule a call"
text="Create TSC discussion "

---
title: 'GraphQL to Simplify Data Access for Cloud Native'
type: WEBINAR
description: 'In this webinar, we’ll look at the emerging role of GraphQL as the unifying query language for federated resources in the modern, cloud-native environment. Between SDKs, REST endpoints, secondary GraphQL schemas.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
description: 'In this webinar, we’ll look at the emerging role of GraphQL as the unifying query language for federated resources in the modern, cloud-native environment. Between SDKs, REST endpoints, secondary GraphQL schemas.
description: 'In this webinar, we’ll look at the emerging role of GraphQL as the unifying query language for federated resources in the modern, cloud-native environment.'

do we actually host webinars? it seems to me we host streams, not webinars.... why not have a streams.md file instead of this current webinar one? 🤔

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@alequetzalli thanks for the review, concerning the list of events, I'm getting rid of them cuz I'm only using em for the sake of view

Copy link
Member

@quetzalliwrites quetzalliwrites left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking forward to your replies to my questions, genuinely wanted to learn more about what you're goals are here so that I can provide useful feedback 😄

@AceTheCreator
Copy link
Member Author

oooh wait, broken image?

Screen Shot 2023-01-30 at 7 25 14 PM

Fixed @alequetzalli

cc @akshatnema @derberg

derberg
derberg previously approved these changes Jan 31, 2023
Copy link
Member

@quetzalliwrites quetzalliwrites left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🙌🏽

components/Meeting.js Outdated Show resolved Hide resolved
Co-authored-by: Akshat Nema <76521428+akshatnema@users.noreply.github.com>
@AceTheCreator AceTheCreator dismissed stale reviews from quetzalliwrites and derberg via 2bdb2d6 February 1, 2023 12:54
AceTheCreator and others added 3 commits February 1, 2023 13:54
Co-authored-by: Akshat Nema <76521428+akshatnema@users.noreply.github.com>
@AceTheCreator
Copy link
Member Author

One last review @akshatnema @derberg @alequetzalli

@akshatnema
Copy link
Member

@AceTheCreator Why the workflow is failing in your PR regarding the links failure?

@AceTheCreator
Copy link
Member Author

@AceTheCreator Why the workflow is failing in your PR regarding the links failure?

No clue, but it's not required I guess

Copy link
Member

@akshatnema akshatnema left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approving this PR but I still have many queries regarding the implementation. We will Improve this in the upcoming PRs.

@akshatnema
Copy link
Member

/rtm

@AceTheCreator
Copy link
Member Author

Approving this PR but I still have many queries regarding the implementation. We will Improve this in the upcoming PRs.

Sorry, what implementation?

@akshatnema
Copy link
Member

Sorry, removing ready-to-mege label as @alequetzalli's review is pending.

@akshatnema
Copy link
Member

Sorry, what implementation?

Like I didn't check the code changes thoroughly, not have looked into your implementation very much. Just made some reviews from the Netlify URL 😅. So, it may happen that I'll have some doubts in my mind that why it is implemented in this way 😄.

Copy link
Member

@quetzalliwrites quetzalliwrites left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚢

@quetzalliwrites
Copy link
Member

O_O

Screen Shot 2023-02-01 at 6 55 14 PM

@AceTheCreator
Copy link
Member Author

/rtm

@asyncapi-bot asyncapi-bot merged commit c6fb6ce into asyncapi:community Feb 3, 2023
@akshatnema akshatnema mentioned this pull request Mar 9, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.