Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: homepage link to studio not matching asyncapi version #1077

Merged
merged 2 commits into from
Nov 8, 2022

Conversation

gabel
Copy link
Contributor

@gabel gabel commented Nov 4, 2022

Description

  • homepage example showing asyncapi 2.5.0 but studio link points to 2.3.0

Bildschirm­foto 2022-11-04 um 13 18 27

Related issue(s)

@netlify
Copy link

netlify bot commented Nov 4, 2022

Deploy Preview for asyncapi-website ready!

Built without sensitive environment variables

Name Link
🔨 Latest commit 2c6f2e7
🔍 Latest deploy log https://app.netlify.com/sites/asyncapi-website/deploys/636a205c75a6df000a422003
😎 Deploy Preview https://deploy-preview-1077--asyncapi-website.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Welcome to AsyncAPI. Thanks a lot for creating your first pull request. Please check out our contributors guide useful for opening a pull request.
Keep in mind there are also other channels you can use to interact with AsyncAPI community. For more details check out this issue.

@github-actions
Copy link

github-actions bot commented Nov 4, 2022

⚡️ Lighthouse report for the changes in this PR:

Category Score
🔴 Performance 49
🟠 Accessibility 88
🟠 Best practices 83
🟢 SEO 100
🔴 PWA 30

Lighthouse ran on https://deploy-preview-1077--asyncapi-website.netlify.app/

fischmart and others added 2 commits November 8, 2022 10:24
@gabel gabel force-pushed the fix/homepage-studio-link branch from 53a72f6 to 2c6f2e7 Compare November 8, 2022 09:24
@magicmatatjahu
Copy link
Member

/rtm

@asyncapi-bot asyncapi-bot merged commit ea4995d into asyncapi:master Nov 8, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants