Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: new tutorial "create asyncapi documents" #1023

Merged
merged 36 commits into from
Feb 24, 2023

Conversation

Annysah
Copy link
Contributor

@Annysah Annysah commented Oct 14, 2022

Description

  • This is the first part on the streetlights tutorial which describes how to "create asyncapi documents"

Related issue(s)
Fixes #850

@netlify
Copy link

netlify bot commented Oct 14, 2022

Deploy Preview for asyncapi-website ready!

Built without sensitive environment variables

Name Link
🔨 Latest commit cda02dd
🔍 Latest deploy log https://app.netlify.com/sites/asyncapi-website/deploys/63f91e032ec14300083834f4
😎 Deploy Preview https://deploy-preview-1023--asyncapi-website.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@Annysah
Copy link
Contributor Author

Annysah commented Oct 14, 2022

Hello @alequetzalli & @derberg , I would love your feedbacks
Thank you!

@github-actions
Copy link

github-actions bot commented Oct 14, 2022

⚡️ Lighthouse report for the changes in this PR:

Category Score
🟠 Performance 51
🟠 Accessibility 88
🟢 Best practices 100
🟢 SEO 100
🔴 PWA 30

Lighthouse ran on https://deploy-preview-1023--asyncapi-website.netlify.app/

Copy link
Member

@derberg derberg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

just 2 suggestions

please take into consideration what I wrote about we vs you in the other Pr

pages/docs/tutorials/create-asyncapi-document.md Outdated Show resolved Hide resolved
pages/docs/tutorials/create-asyncapi-document.md Outdated Show resolved Hide resolved
@Annysah
Copy link
Contributor Author

Annysah commented Oct 22, 2022

Thanks @derberg!
I just sent in my update, kindly have a look.

@quetzalliwrites quetzalliwrites added 📑 docs area/docs Specify what technical area given issue relates to. Its goal is to ease filtering good first issues. gsod This label should be used for issues or discussions related to ideas for Google Season of Docs labels Oct 24, 2022
@quetzalliwrites quetzalliwrites changed the title docs: new streetlights tutorial on how to "create asyncapi documents" docs: new tutorial "create asyncapi documents" Oct 26, 2022
Copy link
Member

@derberg derberg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

sorry, added one more suggestion, I hope you don't mind. The rest lgtm

pages/docs/tutorials/create-asyncapi-document.md Outdated Show resolved Hide resolved
Copy link
Member

@akshatnema akshatnema left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Added some comments

pages/docs/tutorials/create-asyncapi-document.md Outdated Show resolved Hide resolved
pages/docs/tutorials/create-asyncapi-document.md Outdated Show resolved Hide resolved
Co-authored-by: Akshat Nema <76521428+akshatnema@users.noreply.github.com>
Co-authored-by: Akshat Nema <76521428+akshatnema@users.noreply.github.com>
@derberg
Copy link
Member

derberg commented Jan 31, 2023

it has been a while, sorry but I need to clarify

in case of tutorials, didn't we agree that there will always be a CLI command (maybe also studio instruction) that will instruct how to perform tutorial steps? so in the end you can just do asyncapi new SOMETHING and you get the same file generated immediately? to assure tutorials are based on the same example?

something like https://github.com/asyncapi/website/pull/1061/files#diff-8e9be9eabe193de3ae63ce37ae40ca0ab76e4567ed323f605572fa788f48da97R17-R27 that you can see here https://deploy-preview-1061--asyncapi-website.netlify.app/docs/tutorials/message-validation#background-context

@quetzalliwrites
Copy link
Member

it has been a while, sorry but I need to clarify

in case of tutorials, didn't we agree that there will always be a CLI command (maybe also studio instruction) that will instruct how to perform tutorial steps? so in the end you can just do asyncapi new SOMETHING and you get the same file generated immediately? to assure tutorials are based on the same example?

something like https://github.com/asyncapi/website/pull/1061/files#diff-8e9be9eabe193de3ae63ce37ae40ca0ab76e4567ed323f605572fa788f48da97R17-R27 that you can see here https://deploy-preview-1061--asyncapi-website.netlify.app/docs/tutorials/message-validation#background-context

added, we're ready for review again @derberg

quetzalliwrites
quetzalliwrites previously approved these changes Feb 8, 2023
@quetzalliwrites
Copy link
Member

You wrote "this tutorial is about creating asyncapi document, no generation should be mentioned", but then you proceed to add a commit with the word generate 😜 ... nicely going there @derberg ... 😂

Screen Shot 2023-02-08 at 6 43 40 PM

Nice catch tho so thank you... and I fixed it for real 😄✌🏽

Copy link
Member

@quetzalliwrites quetzalliwrites left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

i think it's ok now? 🧐

😄

Copy link
Member

@derberg derberg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

😄

Copy link
Member

@akshatnema akshatnema left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Added some comments.

Go ahead to create the specification documents titled `asyncapi` with a `.yaml` extension.

<CodeBlock>
{`asyncapi: '2.5.0'
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
{`asyncapi: '2.5.0'
{`asyncapi: '2.6.0'

We need to have the latest version of AsyncAPI in Docs.

Let's break it down into pieces:

<CodeBlock>
{`asyncapi: '2.5.0'
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
{`asyncapi: '2.5.0'
{`asyncapi: '2.6.0'

same here...

This tutorial is only a bootstrap; you'll need to add your own business logic into it. Take some time to play with it. There are still lots of things to be covered, but the intent of this tutorial is to make it simple for you to get an idea of the potential.

## Next steps
Now that you've completed this tutorial, go ahead to learn how to [validate your AsyncAPI document with Studio](https://www.asyncapi.com/docs/tutorials/studio-document-validation).
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
Now that you've completed this tutorial, go ahead to learn how to [validate your AsyncAPI document with Studio](https://www.asyncapi.com/docs/tutorials/studio-document-validation).
Now that you've completed this tutorial, go ahead to learn how to [validate your AsyncAPI document with Studio](/docs/tutorials/studio-document-validation).

Also, I think @alequetzalli, you have to make a special dedicated PR to align the Next Steps of each page in Docs, after merging all the Doc pages of gsod 😅. I'm very much confused about the sequence in which pages will be connected, but hope so, it is very much clear to you at the end 😄.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

they are all ready, i already fixed them :P :)

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't think you pushed changed

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I mean pushed changed related to the link https://www.asyncapi.com/docs/tutorials/studio-document-validation

@quetzalliwrites
Copy link
Member

/rtm

@asyncapi-bot asyncapi-bot merged commit 0a35819 into asyncapi:master Feb 24, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/docs Specify what technical area given issue relates to. Its goal is to ease filtering good first issues. 📑 docs gsod This label should be used for issues or discussions related to ideas for Google Season of Docs ready-to-merge
Projects
Status: Done 🚀
Development

Successfully merging this pull request may close these issues.

[📑 Docs]: NEW tutorial, "How to create documentation with AsyncAPI"
5 participants