-
-
Notifications
You must be signed in to change notification settings - Fork 773
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
docs: new guide for validation of AsyncAPI files #1002
Conversation
✅ Deploy Preview for asyncapi-website ready!Built without sensitive environment variables
To edit notification comments on pull requests, go to your Netlify site settings. |
Hello @alequetzalli and @derberg, I would love your feedbacks on this. |
⚡️ Lighthouse report for the changes in this PR:
Lighthouse ran on https://deploy-preview-1002--asyncapi-website.netlify.app/ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looking good 💪🏼
I left some comments. Lemme know if something needs more explanation
pages/docs/guides/validate.md
Outdated
- [AsyncAPI CLI](https://github.com/asyncapi/cli#installation) | ||
- [Spectral](https://meta.stoplight.io/docs/spectral/b8391e051b7d8-installation) | ||
|
||
# Create AsyncAPI documents |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't think you need to explain what asyncapi is.
Turn it into a section that says: "yo, to validate AsyncAPi document, you first need to have one, right 😉 if you did not write one for your app yet, you can easily generate one using one of our examples provided in the AsyncAPI CLI" -> and then line 20-24 is good
Hey @Annysah, how's the next draft coming along? does Lukasz's feedback make sense to you? 😄 |
Haha 😄 yes it does. |
Dear @alequetzalli & @derberg, I would love your feedbacks on the update. Thank you! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
pages/docs/guides/validate.md
Outdated
AsyncAPI provides official [JavaScript](https://github.com/asyncapi/parser-js) and [Go](https://github.com/asyncapi/parser-go) parsers for validating the JSON schema in your AsyncAPI documents. | ||
|
||
<Remember> | ||
If you do not run your schemas through the parsers, the JSON schemas alone cannot complete the entire validation. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If you do not run your schemas through the parsers, the JSON schemas alone cannot complete the entire validation. |
@alequetzalli & @derberg, all done! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
only few tiny comments
Hi @derberg & @alequetzalli, I have updated the changes. |
|
||
--- | ||
|
||
## Additional resources |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
do we need those if they are already linked in previous sections?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think it's great a way to make users access more resources from one place, i.e anyone who just wants to visit the guide can just learn more on the go.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
technically all good from my side
@alequetzalli I guess you need to have a final look.
yaay!! |
Approved, but we can't merge yet because the prev/next buttons point to |
397a172
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
only this Additional resources
section feels weird, but other than that 🟢
/rtm |
Description
Related issue(s)
Fixes #994