Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: new guide for validation of AsyncAPI files #1002

Merged
merged 25 commits into from
Feb 24, 2023

Conversation

Annysah
Copy link
Contributor

@Annysah Annysah commented Oct 5, 2022

Description

  • New guide for validation of AsyncAPI document.

Related issue(s)
Fixes #994

@netlify
Copy link

netlify bot commented Oct 5, 2022

Deploy Preview for asyncapi-website ready!

Built without sensitive environment variables

Name Link
🔨 Latest commit 89c36e0
🔍 Latest deploy log https://app.netlify.com/sites/asyncapi-website/deploys/63f939e4d5b80a0008cde688
😎 Deploy Preview https://deploy-preview-1002--asyncapi-website.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@Annysah
Copy link
Contributor Author

Annysah commented Oct 5, 2022

Hello @alequetzalli and @derberg, I would love your feedbacks on this.
Thank you!

@Annysah Annysah changed the title docs: New guide for validation of AsyncAPI files docs: new guide for validation of AsyncAPI files Oct 5, 2022
@github-actions
Copy link

github-actions bot commented Oct 5, 2022

⚡️ Lighthouse report for the changes in this PR:

Category Score
🟠 Performance 63
🟠 Accessibility 88
🟢 Best practices 100
🟢 SEO 100
🔴 PWA 30

Lighthouse ran on https://deploy-preview-1002--asyncapi-website.netlify.app/

@quetzalliwrites quetzalliwrites added 📑 docs area/docs Specify what technical area given issue relates to. Its goal is to ease filtering good first issues. gsod This label should be used for issues or discussions related to ideas for Google Season of Docs labels Oct 5, 2022
@quetzalliwrites
Copy link
Member

@fmvilas @smoya @derberg This NEW guide is now ready for technical review. ✨

Copy link
Member

@derberg derberg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking good 💪🏼

I left some comments. Lemme know if something needs more explanation

pages/docs/guides/validate.md Outdated Show resolved Hide resolved
pages/docs/guides/validate.md Outdated Show resolved Hide resolved
- [AsyncAPI CLI](https://github.com/asyncapi/cli#installation)
- [Spectral](https://meta.stoplight.io/docs/spectral/b8391e051b7d8-installation)

# Create AsyncAPI documents
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't think you need to explain what asyncapi is.

Turn it into a section that says: "yo, to validate AsyncAPi document, you first need to have one, right 😉 if you did not write one for your app yet, you can easily generate one using one of our examples provided in the AsyncAPI CLI" -> and then line 20-24 is good

pages/docs/guides/validate.md Outdated Show resolved Hide resolved
pages/docs/guides/validate.md Outdated Show resolved Hide resolved
pages/docs/guides/validate.md Outdated Show resolved Hide resolved
pages/docs/guides/validate.md Outdated Show resolved Hide resolved
pages/docs/guides/validate.md Outdated Show resolved Hide resolved
pages/docs/guides/validate.md Outdated Show resolved Hide resolved
pages/docs/guides/validate.md Show resolved Hide resolved
@quetzalliwrites
Copy link
Member

Hey @Annysah, how's the next draft coming along? does Lukasz's feedback make sense to you? 😄

@Annysah
Copy link
Contributor Author

Annysah commented Nov 6, 2022

Hey @Annysah, how's the next draft coming along? does Lukasz's feedback make sense to you? 😄

Haha 😄 yes it does.

@Annysah
Copy link
Contributor Author

Annysah commented Nov 7, 2022

Dear @alequetzalli & @derberg, I would love your feedbacks on the update. Thank you!

Copy link
Member

@derberg derberg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's looking great, just added only 2 comments, to clarify a bit with more context.

Also huge request, when you address a comment, please add 👍🏼 emoji, or comment or click Resolve conversation as it is hard to figure if you addressed it or not. Thanks 🙏🏼

Screenshot 2022-11-08 at 16 59 13

AsyncAPI provides official [JavaScript](https://github.com/asyncapi/parser-js) and [Go](https://github.com/asyncapi/parser-go) parsers for validating the JSON schema in your AsyncAPI documents.

<Remember>
If you do not run your schemas through the parsers, the JSON schemas alone cannot complete the entire validation.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
If you do not run your schemas through the parsers, the JSON schemas alone cannot complete the entire validation.

pages/docs/guides/validate.md Outdated Show resolved Hide resolved
@Annysah
Copy link
Contributor Author

Annysah commented Nov 18, 2022

@alequetzalli & @derberg, all done!

Copy link
Member

@derberg derberg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

only few tiny comments

pages/docs/guides/validate.md Outdated Show resolved Hide resolved
pages/docs/guides/validate.md Outdated Show resolved Hide resolved
pages/docs/guides/validate.md Outdated Show resolved Hide resolved
@Annysah
Copy link
Contributor Author

Annysah commented Nov 25, 2022

Hi @derberg & @alequetzalli, I have updated the changes.
Kindly review. Thank you!


---

## Additional resources
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

do we need those if they are already linked in previous sections?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think it's great a way to make users access more resources from one place, i.e anyone who just wants to visit the guide can just learn more on the go.

pages/docs/guides/validate.md Outdated Show resolved Hide resolved
pages/docs/guides/validate.md Outdated Show resolved Hide resolved
derberg
derberg previously approved these changes Dec 12, 2022
Copy link
Member

@derberg derberg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

technically all good from my side

@alequetzalli I guess you need to have a final look.

@Annysah
Copy link
Contributor Author

Annysah commented Dec 13, 2022

technically all good from my side

@alequetzalli I guess you need to have a final look.

yaay!!

@quetzalliwrites
Copy link
Member

Approved, but we can't merge yet because the prev/next buttons point to message validation guide PR #1005 which @starlightknown is still working on 😄

@derberg

@quetzalliwrites quetzalliwrites dismissed stale reviews from derberg and themself via 397a172 January 25, 2023 02:17
Copy link
Member

@derberg derberg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

only this Additional resources section feels weird, but other than that 🟢

@quetzalliwrites
Copy link
Member

/rtm

@asyncapi-bot asyncapi-bot merged commit e762b58 into asyncapi:master Feb 24, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/docs Specify what technical area given issue relates to. Its goal is to ease filtering good first issues. 📑 docs gsod This label should be used for issues or discussions related to ideas for Google Season of Docs ready-to-merge
Projects
Status: Done 🚀
Development

Successfully merging this pull request may close these issues.

[📑 Docs]: add 5th content bucket to docs for guides
4 participants