-
-
Notifications
You must be signed in to change notification settings - Fork 13
chore: update modelina dependency #488
chore: update modelina dependency #488
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I accept, but I have one comment.
template/src/models/models.js
Outdated
import { Parser } from '@asyncapi/parserV2'; | ||
const parser = new Parser(); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You should also register custom parsers from @asyncapi/parserV2/cjs/schema-parser/**
https://github.com/asyncapi/parser-js/tree/next-major/src/schema-parser
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Right... Effectively it's not possible to use any other input atm..
I don't know, I don't really want to use redefine the entire parser functionality here, also because I don't think it can process local references.
Not sure if you see a better approach then this?
This pull request has been automatically marked as stale because it has not had recent activity 😴 It will be closed in 120 days if no further activity occurs. To unstale this pull request, add a comment with detailed explanation. There can be many reasons why some specific pull request has no activity. The most probable cause is lack of time, not lack of interest. AsyncAPI Initiative is a Linux Foundation project not owned by a single for-profit company. It is a community-driven initiative ruled under open governance model. Let us figure out together how to push this pull request forward. Connect with us through one of many communication channels we established here. Thank you for your patience ❤️ |
Description
This PR switches to the new Modelina dependency