Skip to content
This repository has been archived by the owner on Oct 2, 2024. It is now read-only.

chore: update modelina dependency #488

Closed

Conversation

jonaslagoni
Copy link
Member

Description
This PR switches to the new Modelina dependency

package.json Outdated Show resolved Hide resolved
package.json Outdated Show resolved Hide resolved
magicmatatjahu
magicmatatjahu previously approved these changes Nov 17, 2022
Copy link
Member

@magicmatatjahu magicmatatjahu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I accept, but I have one comment.

Comment on lines 4 to 5
import { Parser } from '@asyncapi/parserV2';
const parser = new Parser();
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You should also register custom parsers from @asyncapi/parserV2/cjs/schema-parser/**

https://github.com/asyncapi/parser-js/tree/next-major/src/schema-parser

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Right... Effectively it's not possible to use any other input atm..

I don't know, I don't really want to use redefine the entire parser functionality here, also because I don't think it can process local references.

Not sure if you see a better approach then this?

@github-actions
Copy link

This pull request has been automatically marked as stale because it has not had recent activity 😴

It will be closed in 120 days if no further activity occurs. To unstale this pull request, add a comment with detailed explanation.

There can be many reasons why some specific pull request has no activity. The most probable cause is lack of time, not lack of interest. AsyncAPI Initiative is a Linux Foundation project not owned by a single for-profit company. It is a community-driven initiative ruled under open governance model.

Let us figure out together how to push this pull request forward. Connect with us through one of many communication channels we established here.

Thank you for your patience ❤️

@github-actions github-actions bot added the stale label May 18, 2023
@github-actions github-actions bot closed this Sep 15, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants