Add Form component #773
Merged
Add Form component #773
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Co-authored-by: asyncapi-bot <info@asyncapi.io>
Co-authored-by: asyncapi-bot <info@asyncapi.io>
Co-authored-by: asyncapi-bot <info@asyncapi.io>
Co-authored-by: asyncapi-bot <info@asyncapi.io>
Co-authored-by: asyncapi-bot <info@asyncapi.io>
fmvilas
requested changes
Apr 29, 2024
There was a problem hiding this comment.
In general, it looks amazing to me but found some gotchas.
Something I couldn't point in code is that the cursor of the DropdownMenu items is a text cursor (the one that looks like a capital i). It should be the arrow pointer (cursor-default class in Tailwind).
Co-authored-by: Fran Méndez <fmvilas@gmail.com>
Co-authored-by: Fran Méndez <fmvilas@gmail.com>
|
@fmvilas the changes have been made. |
princerajpoot20
previously approved these changes
May 1, 2024
|
|
/rtm |
|
/rtm |
KhudaDad414
added a commit
to KhudaDad414/studio
that referenced
this pull request
Jun 4, 2024
Co-authored-by: samz <samir.amzani@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR introduces several enhancements to the
@asyncapi/studio-uipackage, specifically focusing on the form components.Changes
New Form Components: Added the following new components along with stories:
Storybook Updates: Added support for tailwinds in stories for testing the components.
Related issue(s)
Resolves #752