Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add slideover component #711

Merged
merged 14 commits into from
Jul 4, 2023

Conversation

princerajpoot20
Copy link
Member

Description

@netlify
Copy link

netlify bot commented Jul 2, 2023

Deploy Preview for modest-rosalind-098b67 ready!

Name Link
🔨 Latest commit c705381
🔍 Latest deploy log https://app.netlify.com/sites/modest-rosalind-098b67/deploys/64a3ebc782e9ac0007f42261
😎 Deploy Preview https://deploy-preview-711--modest-rosalind-098b67.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@netlify
Copy link

netlify bot commented Jul 2, 2023

Deploy Preview for asyncapi-studio-design-system ready!

Name Link
🔨 Latest commit c705381
🔍 Latest deploy log https://app.netlify.com/sites/asyncapi-studio-design-system/deploys/64a3ebc7ff51a300087f22da
😎 Deploy Preview https://deploy-preview-711--asyncapi-studio-design-system.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link
Member

@fmvilas fmvilas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That was fast! Left a few comments :)

packages/ui/components/SlideOver.tsx Outdated Show resolved Hide resolved
packages/ui/components/SlideOver.tsx Outdated Show resolved Hide resolved
packages/ui/components/SlideOver.tsx Outdated Show resolved Hide resolved
packages/ui/components/SlideOver.tsx Outdated Show resolved Hide resolved
packages/ui/components/SlideOver.tsx Outdated Show resolved Hide resolved
apps/design-system/src/components/SlideOver.stories.tsx Outdated Show resolved Hide resolved
@princerajpoot20
Copy link
Member Author

@fmvilas Done 🫡

packages/ui/components/SlideOver.tsx Outdated Show resolved Hide resolved
packages/ui/components/SlideOver.tsx Outdated Show resolved Hide resolved
Copy link
Member

@fmvilas fmvilas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changed the padding to make it look like the design and made the story render as dark mode by default so we can properly see the border and everything.

@sonarqubecloud
Copy link

sonarqubecloud bot commented Jul 4, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@fmvilas
Copy link
Member

fmvilas commented Jul 4, 2023

/rtm

@asyncapi-bot asyncapi-bot merged commit 6d235a0 into asyncapi:master Jul 4, 2023
@fmvilas
Copy link
Member

fmvilas commented Jul 4, 2023

Congrats! Second PR in a week! 🙌

@asyncapi-bot
Copy link
Contributor

🎉 This PR is included in version ui-v1.1.0 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

@asyncapi-bot
Copy link
Contributor

🎉 This PR is included in version design-system-v1.1.0 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

@princerajpoot20
Copy link
Member Author

@fmvilas It's all because of you. Thankyou for your support. 🙂

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

SlideOver component
3 participants