-
-
Notifications
You must be signed in to change notification settings - Fork 103
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add slideover component #711
feat: add slideover component #711
Conversation
✅ Deploy Preview for modest-rosalind-098b67 ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
✅ Deploy Preview for asyncapi-studio-design-system ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
That was fast! Left a few comments :)
@fmvilas Done 🫡 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Changed the padding to make it look like the design and made the story render as dark mode by default so we can properly see the border and everything.
Co-authored-by: Fran Méndez <fmvilas@gmail.com>
Co-authored-by: Fran Méndez <fmvilas@gmail.com>
Kudos, SonarCloud Quality Gate passed!
|
/rtm |
Congrats! Second PR in a week! 🙌 |
🎉 This PR is included in version ui-v1.1.0 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
🎉 This PR is included in version design-system-v1.1.0 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
@fmvilas It's all because of you. Thankyou for your support. 🙂 |
Description
Resolve SlideOver component #674