Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add operation icon component #708

Merged
merged 4 commits into from
Jul 1, 2023
Merged

feat: add operation icon component #708

merged 4 commits into from
Jul 1, 2023

Conversation

princerajpoot20
Copy link
Member

@princerajpoot20 princerajpoot20 commented Jul 1, 2023

Resolves #670

@netlify
Copy link

netlify bot commented Jul 1, 2023

Deploy Preview for modest-rosalind-098b67 ready!

Name Link
🔨 Latest commit db8bbb1
🔍 Latest deploy log https://app.netlify.com/sites/modest-rosalind-098b67/deploys/64a0883da2fc150008871fa6
😎 Deploy Preview https://deploy-preview-708--modest-rosalind-098b67.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@netlify
Copy link

netlify bot commented Jul 1, 2023

Deploy Preview for asyncapi-studio-design-system ready!

Name Link
🔨 Latest commit db8bbb1
🔍 Latest deploy log https://app.netlify.com/sites/asyncapi-studio-design-system/deploys/64a0883d3350250008afb372
😎 Deploy Preview https://deploy-preview-708--asyncapi-studio-design-system.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Welcome to AsyncAPI. Thanks a lot for creating your first pull request. Please check out our contributors guide useful for opening a pull request.
Keep in mind there are also other channels you can use to interact with AsyncAPI community. For more details check out this issue.

Copy link
Member

@fmvilas fmvilas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's almost there! If you want to check if this is working, you gotta run the design system locally:

npm run ds

This should be done from the root directory of the repo. Then access http://localhost:6006 and you should see something like this: https://atoms.asyncapi.com/

packages/ui/components/OperationIcon.tsx Show resolved Hide resolved
packages/ui/components/OperationIcon.tsx Outdated Show resolved Hide resolved
packages/ui/components/OperationIcon.tsx Outdated Show resolved Hide resolved
packages/ui/components/OperationIcon.tsx Outdated Show resolved Hide resolved
@princerajpoot20
Copy link
Member Author

@fmvilas I have made the changes.
Screenshot 2023-07-01 at 7 30 33 PM
This is how it looks.

packages/ui/components/OperationIcon.tsx Outdated Show resolved Hide resolved
packages/ui/components/OperationIcon.tsx Outdated Show resolved Hide resolved
@princerajpoot20
Copy link
Member Author

@fmvilas I think we got this now!! 🎉

@princerajpoot20 princerajpoot20 changed the title feat: initial draft for operation icon feat: add operation icon component Jul 1, 2023
@fmvilas
Copy link
Member

fmvilas commented Jul 1, 2023

It's definitely done. Just left some comments to clarify.

@sonarqubecloud
Copy link

sonarqubecloud bot commented Jul 1, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@princerajpoot20
Copy link
Member Author

@fmvilas Done 👍

@fmvilas
Copy link
Member

fmvilas commented Jul 1, 2023

/rtm

@asyncapi-bot asyncapi-bot merged commit e4068b5 into asyncapi:master Jul 1, 2023
@fmvilas
Copy link
Member

fmvilas commented Jul 1, 2023

Great stuff mate 🙌

@asyncapi-bot
Copy link
Contributor

🎉 This PR is included in version ui-v1.0.0 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

@asyncapi-bot
Copy link
Contributor

🎉 This PR is included in version design-system-v1.0.0 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

@princerajpoot20 princerajpoot20 deleted the operation-icon branch July 2, 2023 12:23
@princerajpoot20 princerajpoot20 restored the operation-icon branch July 2, 2023 12:26
@princerajpoot20 princerajpoot20 deleted the operation-icon branch July 2, 2023 12:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Operation Icon component
3 participants