-
-
Notifications
You must be signed in to change notification settings - Fork 104
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add operation icon component #708
Conversation
✅ Deploy Preview for modest-rosalind-098b67 ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
✅ Deploy Preview for asyncapi-studio-design-system ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Welcome to AsyncAPI. Thanks a lot for creating your first pull request. Please check out our contributors guide useful for opening a pull request.
Keep in mind there are also other channels you can use to interact with AsyncAPI community. For more details check out this issue.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It's almost there! If you want to check if this is working, you gotta run the design system locally:
npm run ds
This should be done from the root directory of the repo. Then access http://localhost:6006 and you should see something like this: https://atoms.asyncapi.com/
@fmvilas I have made the changes. |
@fmvilas I think we got this now!! 🎉 |
It's definitely done. Just left some comments to clarify. |
Kudos, SonarCloud Quality Gate passed!
|
@fmvilas Done 👍 |
/rtm |
Great stuff mate 🙌 |
🎉 This PR is included in version ui-v1.0.0 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
🎉 This PR is included in version design-system-v1.0.0 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
Resolves #670