Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: remove package-lock.json files from apps + fix script #682

Merged
merged 1 commit into from
Jun 21, 2023

Conversation

smoya
Copy link
Member

@smoya smoya commented Jun 21, 2023

Description

Turborepo seems to manage everything through one global package-lock.json file, the one located in the root of the repository. The rest are not needed.

This PR also fixes the run studio script which was running the design system instead.

@netlify
Copy link

netlify bot commented Jun 21, 2023

Deploy Preview for modest-rosalind-098b67 ready!

Name Link
🔨 Latest commit 137789c
🔍 Latest deploy log https://app.netlify.com/sites/modest-rosalind-098b67/deploys/6492e79d2f8b2c0008f02cee
😎 Deploy Preview https://deploy-preview-682--modest-rosalind-098b67.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@netlify
Copy link

netlify bot commented Jun 21, 2023

Deploy Preview for asyncapi-studio-design-system ready!

Name Link
🔨 Latest commit 137789c
🔍 Latest deploy log https://app.netlify.com/sites/asyncapi-studio-design-system/deploys/6492e79d0a21c40008536dea
😎 Deploy Preview https://deploy-preview-682--asyncapi-studio-design-system.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.3% 0.3% Duplication

Copy link
Member

@KhudaDad414 KhudaDad414 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

makes sense.

@smoya
Copy link
Member Author

smoya commented Jun 21, 2023

/rtm

@asyncapi-bot asyncapi-bot merged commit 6f8af66 into asyncapi:master Jun 21, 2023
@smoya smoya deleted the chore/fixPackages branch June 21, 2023 13:15
@asyncapi-bot
Copy link
Contributor

🎉 This PR is included in version design-system-v1.0.0 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

@asyncapi-bot
Copy link
Contributor

🎉 This PR is included in version @asyncapi/studio-v1.0.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

@asyncapi-bot
Copy link
Contributor

🎉 This PR is included in version design-system-v1.0.0 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

@asyncapi-bot
Copy link
Contributor

🎉 This PR is included in version @asyncapi/studio-v1.0.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants