fix: report correct range values in error diagnostics for YAML files
#1126
+197
−82
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aeworxet
requested review from
magicmatatjahu,
KhudaDad414,
Amzani and
asyncapi-bot-eve
as code owners
🦋 Changeset detectedLatest commit: 416e9d9 The changes in this PR will be included in the next version bump. This PR includes changesets to release 2 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
✅ Deploy Preview for studio-next ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
✅ Deploy Preview for modest-rosalind-098b67 ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
✅ Deploy Preview for asyncapi-studio-design-system ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
|
|
@asyncapi/bounty_team |
|
/ptal |
|
@Amzani @magicmatatjahu @KhudaDad414 Please take a look at this PR. Thanks! 👋 |
|
/rtm |
2 tasks
This was referenced Sep 1, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR updates
@asyncapi/parserto version3.2.2in which forceful normalization of YAML files to JSON format is removed. That change allowsParsernot to be misled anymore into thinking it's dealing with a JSON file instead of a YAML one, therefore paving the way forStudioto report correctrangevalues in error diagnostics for YAML files.Related to asyncapi/parser-js#936, asyncapi/parser-js#1012