fix: remove action and channel fields from Operation Trait Object #860
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
magicmatatjahu
requested review from
fmvilas,
derberg,
dalelane,
smoya,
char0n and
asyncapi-bot-eve
as code owners
|
Kudos, SonarCloud Quality Gate passed!
|
smoya
approved these changes
Oct 27, 2022
|
@magicmatatjahu fyi you have 3 approvals out of 5 codeowners, you can merge when you're ready will you update JSON Schema? |
Yes I will. If 3 people are in favor of it (are you too? 😄) then I merge it. |
in favour of what 😅 |
|
Of my changes in this PR 😆 |
You have 3 approvals |
|
/rtm |
|
🎉 This PR is included in version 3.0.0-next-major-spec.5 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
This was referenced Nov 9, 2022
GreenRover
pushed a commit
to GreenRover/asyncapi-spec
that referenced
this pull request
Jan 18, 2023
6 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
title: "remove action and channel fields from Operation Trait Object"
Related issue(s):
#856
This PR only shows what changes should be done described in the mentioned issue (#856). If we decide to leave these fields, I will close the PR.
I think the ability to define
channelandactionat the trait level is bad, because both fields are required by the operation itself.