fix: implementation of adding custom keys to a problem object

asyncapi · Aug 27, 2022 · a954331 · a954331
1 parent 77b0122
commit a954331
Show file tree

Hide file tree

Showing 3 changed files with 16 additions and 4 deletions.
diff --git a/__tests__/index.test.ts b/__tests__/index.test.ts
@@ -6,7 +6,8 @@ const _testContext = new ProblemContextHelper();
 describe("Class Methods Test Suite", () => {
   test("Create Class with Custom Keys", () => {
     const customKey = "RCA";
-    const testProblem = new Problem(_testContext._problemInstance, ["RCA"]);
+    _testContext._problemInstance[customKey]="Root Cause Analysis"
+    const testProblem = new Problem(_testContext._problemInstance);
     expect(testProblem).toHaveProperty(customKey);
   });
 

diff --git a/src/constants.ts b/src/constants.ts
@@ -0,0 +1,8 @@
+export const DEFAULT_KEYS = [
+  "http",
+  "type",
+  "title",
+  "detail",
+  "instance",
+  "stack",
+];
diff --git a/src/problem.ts b/src/problem.ts
@@ -1,3 +1,4 @@
+import { DEFAULT_KEYS } from "./constants";
 import {
   httpObject,
   ProblemInterface,
@@ -26,9 +27,11 @@ export class Problem extends Error implements ProblemInterface {
     this.detail = problem.detail;
     this.instance = problem.instance;
     this.stack = problem.stack;
-    customKeys?.map((customKey) => {
-      this[customKey] = problem[customKey];
-    });
+
+    // add extra keys
+    Object.keys(problem)
+      .filter((el) => !DEFAULT_KEYS.includes(el))
+      .forEach((k) => (this[k] = problem[k]));
   }
 
   copy(problem: ProblemInterface, mode: COPY_MODE, props: string[]): Problem {