Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Getting this template released #151

Closed
derberg opened this issue Sep 22, 2022 · 7 comments · Fixed by #165
Closed

Getting this template released #151

derberg opened this issue Sep 22, 2022 · 7 comments · Fixed by #165
Labels
enhancement New feature or request

Comments

@derberg
Copy link
Member

derberg commented Sep 22, 2022

@emilianozublena hey, wanted to check with you what are your plans for this template. If you still want to maintain it, as I was thinking, basing on the fact that it got contribution and there are starts, that we should finally release it as official asyncapi template.

But of course it makes sense only if it is going to be maintained

@derberg derberg added the enhancement New feature or request label Sep 22, 2022
@github-actions
Copy link

Welcome to AsyncAPI. Thanks a lot for reporting your first issue. Please check out our contributors guide and the instructions about a basic recommended setup useful for opening a pull request.
Keep in mind there are also other channels you can use to interact with AsyncAPI community. For more details check out this issue.

@emilianozublena
Copy link
Member

Sorry for the late response @derberg, trying to get back into a more active state around this template. I'd publish it ofc, i'll make sure to answer any potential issues/PR's back and also work around a few things that we can improve.

@derberg
Copy link
Member Author

derberg commented Dec 1, 2022

@emilianozublena in Poland we say "better late than never" 😆

good to see you back and that you want to be more active here. I was recently approached by one guy from Poland concerned about the state of the template. I think he was willing to contribute 😄

@Ferror good news, Emiliano is back 💪🏼 we probably brought him with our thoughts 😄 I suggest you open the issue and describe your ideas for improvements there.

And please folks, forget about yesterday's game. We let you @emilianozublena win because Lewandowski felt sorry for Messi not scoring the penalty. Normally Poland plays better football, at least I hope so 🤣

@emilianozublena
Copy link
Member

Awesome to hear someone's willing to contribute, that'll make things easier for sure. Open to any PR's or even issues like this to discuss of things we need to change/improve and/or add :)

@derberg i saw messi and lewandoski arguing, i think that prbly he told messi that now they're even lol

@emilianozublena
Copy link
Member

Should we close this issue and let @Ferror open a new one to start chatting about it? @derberg

@derberg
Copy link
Member Author

derberg commented Dec 19, 2022

I definitely recommend running a separate issue about possible contributions. But please leave this one open. In the coming days I will contribute PR that will enable automated releases in this template.

Would be great if you could rename this repo from asyncapi-php-template to php-template as it is already under asyncapi and npm name will be @asyncapi/php-template

@emilianozublena
Copy link
Member

Great, that makes sense, at least start collecting the list of things we want to tackle first, i'll make sure to create that and start the convo with @Ferror.

Can't find the rename option i usually see under settings, could there be something around permissions that we need to review @derberg ?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants