feat!: add support for multi-format schemas #100
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Additionally, schema.format() will always return a value. Will return the default format if undefined.
|
Changes are now moved into #86. Closing this one |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Required for and implemented in asyncapi/parser-js#814.
Additionally, schema.format() will always return a value. Will return the default format if undefined. This is BC.
Alternative for the BC is to keep the previous interface
format(): string | undefinedbut from now on implementations will never return undefined.As this Parser-API is in early stages, I think we could release a major version with such a change and avoid carrying this in the future. WDYT?
cc @fmvilas
Related issue(s)