-
-
Notifications
You must be signed in to change notification settings - Fork 197
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: improved formatting for C# #724
chore: improved formatting for C# #724
Conversation
# Conflicts: # src/generators/csharp/renderers/ClassRenderer.ts
Pull Request Test Coverage Report for Build 2211797647
💛 - Coveralls |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is great 🔥
Had a few comments 🙂
Co-authored-by: Jonas Lagoni <jonas-lt@live.dk>
Co-authored-by: Jonas Lagoni <jonas-lt@live.dk>
There are a few failing snapshots @slowikowskiarkadiusz. Would you mind updating them ? |
Kudos, SonarCloud Quality Gate passed!
|
Should be in place now :) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 👍
/rtm
Gonna use |
🎉 This PR is included in version 0.56.4 🎉 The release is available on: Your semantic-release bot 📦🚀 |
🎉 This PR is included in version 1.0.0-next.23 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Description
In this PR I resolve most issues with formatting of the generated C# code, accordingly to conventions I've observed as a C# programmer. The changes include:
There might be also other issues than those that remain unresolved, but I think the generated code is going to look much more up to the standard.
No docs changes are required IMO.
Related issue(s)
Just a chore, I don't think it's worth making an issue