Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: new accessor preset hook for C# class renderer #626

Merged
merged 7 commits into from
Feb 16, 2022
Merged

feat: new accessor preset hook for C# class renderer #626

merged 7 commits into from
Feb 16, 2022

Conversation

jonaslagoni
Copy link
Member

@jonaslagoni jonaslagoni commented Feb 9, 2022 •
edited
Loading

Description
This PR adds a new preset hook called accessor which is used to overwrite the accessor builder code that wraps the getter and setter methods.

This is needed if you want to disable the entire accessor code.

Related issue(s)
Related to #615
Related example that required it #627

@coveralls
Copy link

coveralls commented Feb 9, 2022 •
edited
Loading

Pull Request Test Coverage Report for Build 1849026989

  • 11 of 11 (100.0%) changed or added relevant lines in 1 file are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage decreased (-0.02%) to 93.431%
Totals Coverage Status
Change from base Build 1846970141: -0.02%
Covered Lines: 2526
Relevant Lines: 2577
💛 - Coveralls

This was referenced Feb 9, 2022
Merged
Closed
magicmatatjahu
magicmatatjahu reviewed Feb 11, 2022
View reviewed changes
Copy link
Member

@magicmatatjahu magicmatatjahu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One simple question before review, because I don't understand that new feature.

@jonaslagoni jonaslagoni changed the title feat: new accessorBuilder preset hook for C# class renderer feat: new accessor preset hook for C# class renderer Feb 14, 2022
@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

magicmatatjahu
magicmatatjahu approved these changes Feb 16, 2022
View reviewed changes
Copy link
Member

@magicmatatjahu magicmatatjahu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jonaslagoni jonaslagoni merged commit c773f4c into asyncapi:master Feb 16, 2022
@jonaslagoni jonaslagoni deleted the feature/accessor_builder_preset_hook branch February 16, 2022 15:24
@asyncapi-bot
Copy link
Contributor

🎉 This PR is included in version 0.49.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

@asyncapi-bot
Copy link
Contributor

🎉 This PR is included in version 1.0.0-next.23 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@magicmatatjahu magicmatatjahu magicmatatjahu approved these changes

Assignees
No one assigned
Labels
released on @next released
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@jonaslagoni @coveralls @asyncapi-bot @magicmatatjahu