Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

docs: generate Java data models that overwrite hashCode method #580

Merged
merged 3 commits into from
Jan 12, 2022
Merged

docs: generate Java data models that overwrite hashCode method #580

merged 3 commits into from
Jan 12, 2022

Conversation

mahakporwal02
Copy link
Contributor

@mahakporwal02 mahakporwal02 commented Jan 12, 2022 •
edited
Loading

@coveralls
Copy link

coveralls commented Jan 12, 2022 •
edited
Loading

Pull Request Test Coverage Report for Build 1689413561

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 93.575%
Totals Coverage Status
Change from base Build 1684708991: 0.0%
Covered Lines: 2368
Relevant Lines: 2414
💛 - Coveralls

jonaslagoni
jonaslagoni requested changes Jan 12, 2022
View reviewed changes
Copy link
Member

@jonaslagoni jonaslagoni left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💪

Small change, all the places where you wrote GetHashCode needs to be renamed to hashCode, as GetHashCode is for C# 🙂

@mahakporwal02 mahakporwal02 changed the title docs: generate Java data models that overwrite GetHashCode method docs: generate Java data models that overwrite hashCode method Jan 12, 2022
@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

jonaslagoni
jonaslagoni approved these changes Jan 12, 2022
View reviewed changes
Copy link
Member

@jonaslagoni jonaslagoni left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@jonaslagoni jonaslagoni merged commit d9266db into asyncapi:master Jan 12, 2022
@asyncapi-bot
Copy link
Contributor

🎉 This PR is included in version 0.44.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

@asyncapi-bot
Copy link
Contributor

🎉 This PR is included in version 1.0.0-next.23 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jonaslagoni jonaslagoni jonaslagoni approved these changes

Assignees
No one assigned
Labels
released on @next released
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Show how to generate Java data models that overwrite hashCode method
4 participants
@mahakporwal02 @coveralls @asyncapi-bot @jonaslagoni