Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

docs: model to change collection types for Java models #579

Merged
merged 6 commits into from
Jan 13, 2022
Merged

docs: model to change collection types for Java models #579

merged 6 commits into from
Jan 13, 2022

Conversation

ron-debajyoti
Copy link
Contributor

Description

  • Added example for changing collection types to List in Java
  • Updated relevant docs
  • Added the test and its respective snapshot

Related issue(s)

Fixes #424

@ron-debajyoti ron-debajyoti changed the title docs: change collection types for Java models docs: model to change collection types for Java models Jan 12, 2022
jonaslagoni
jonaslagoni requested changes Jan 12, 2022
View reviewed changes
Copy link
Member

@jonaslagoni jonaslagoni left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💪

Had a few comments 🙂

@coveralls
Copy link

coveralls commented Jan 13, 2022 •
edited
Loading

Pull Request Test Coverage Report for Build 1692194378

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 93.575%
Totals Coverage Status
Change from base Build 1689794813: 0.0%
Covered Lines: 2368
Relevant Lines: 2414
💛 - Coveralls

@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@ron-debajyoti
Copy link
Contributor Author

@jonaslagoni sorry for being late. Please check the latest updates.

jonaslagoni
jonaslagoni approved these changes Jan 13, 2022
View reviewed changes
Copy link
Member

@jonaslagoni jonaslagoni left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There is nothing about being late, it takes the time it take, so don't worry about it 😄

LGTM 👍

@jonaslagoni jonaslagoni merged commit 17273c1 into asyncapi:master Jan 13, 2022
@asyncapi-bot
Copy link
Contributor

🎉 This PR is included in version 0.44.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

@asyncapi-bot
Copy link
Contributor

🎉 This PR is included in version 1.0.0-next.23 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jonaslagoni jonaslagoni jonaslagoni approved these changes

Assignees
No one assigned
Labels
released on @next released
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Show how to change collection types for Java data models
4 participants
@ron-debajyoti @coveralls @asyncapi-bot @jonaslagoni