fix!: when allowInheritance is true, java now renders setters in interfaces for enums if const is not set by the classes that implements it #2096
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…faces for enums if const is not set by the classes that implements it
✅ Deploy Preview for modelina canceled.
|
kennethaasan
requested review from
magicmatatjahu,
jonaslagoni and
asyncapi-bot-eve
as code owners
…faces for enums if const is not set by the classes that implements it
…faces for enums if const is not set by the classes that implements it
|
jonaslagoni
approved these changes
Sep 5, 2024
|
🎉 This PR is included in version 4.0.0-next.60 🎉 The release is available on: Your semantic-release bot 📦🚀 |
4 tasks
|
🎉 This issue has been resolved in version 4.0.0-next.61 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
#2068 introduced some breaking changes for the Java code that Java users didn't like. They want setters when they can exist, and this fixes that.
In Java, when a class implements an interface, it must implement all the methods of that interface. Therefore, if
allowInheritanceis set to true, Modelina will no longer render the setter for enums in interfaces if the property exists in the implemented by class with a constant value.Related Issue
Checklist
npm run lint).npm run test).Additional Notes
Fixes #2068