Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add modelName to warning log #1997

Merged
merged 2 commits into from
May 13, 2024
Merged

feat: add modelName to warning log #1997

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
c76921c
Adding modelName to warning log to know which model conversion is run…
May 11, 2024
6729605
addressing linter issue to add a new line.
gitankit7 May 12, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/helpers/CommonModelToMetaModel.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -121,7 +121,7 @@
if (booleanModel !== undefined) {
return booleanModel;
}
Logger.warn('Failed to convert to MetaModel, defaulting to AnyModel');
Logger.warn(`Failed to convert ${modelName} to MetaModel, defaulting to AnyModel`);

Check failure on line 124 in src/helpers/CommonModelToMetaModel.ts

View workflow job for this annotation

GitHub Actions / Test NodeJS PR - ubuntu-latest 

Replace ``Failed·to·convert·${modelName}·to·MetaModel,·defaulting·to·AnyModel`` with `⏎····`Failed·to·convert·${modelName}·to·MetaModel,·defaulting·to·AnyModel`⏎··`
return new AnyModel(
modelName,
jsonSchemaModel.originalInput,
Expand Down
Loading