Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

style(website): redesign homepage #1733

Merged
merged 4 commits into from
Jan 18, 2024

Conversation

devilkiller-ag
Copy link
Member

Description

This PR is to redesign the hero of the website as discussed in issue #1293.

Checklist

  • The code follows the project's coding standards and is properly linted (npm run lint).
  • Tests have been added or updated to cover the changes.
  • Documentation has been updated to reflect the changes.
  • All tests pass successfully locally.(npm run test).

@devilkiller-ag devilkiller-ag self-assigned this Jan 9, 2024
Copy link

netlify bot commented Jan 9, 2024

Deploy Preview for modelina ready!

Name Link
🔨 Latest commit 7778031
🔍 Latest deploy log https://app.netlify.com/sites/modelina/deploys/65a79a294a875e0008514612
😎 Deploy Preview https://deploy-preview-1733--modelina.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@devilkiller-ag devilkiller-ag changed the title Redesign Hero Section style(website): redesign hero section Jan 9, 2024
@coveralls
Copy link

coveralls commented Jan 9, 2024

Pull Request Test Coverage Report for Build 7553458077

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 92.364%

Totals Coverage Status
Change from base Build 7494950412: 0.0%
Covered Lines: 5869
Relevant Lines: 6193

💛 - Coveralls

Copy link
Member

@jonaslagoni jonaslagoni left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The code boxes are not scrollable on mobile 🤔

@devilkiller-ag
Copy link
Member Author

devilkiller-ag commented Jan 10, 2024

The code boxes are not scrollable on mobile 🤔

Are you talking about the code boxes in the usage section? I will be working on that section just after this PR. I will most probably change the mobile layout of this section. But for now I will add scrollbar into these code boxes. Or should I do the usage redesign also in this PR?

@jonaslagoni
Copy link
Member

Up to you @devilkiller-ag, just let me know when to review again 😄

@devilkiller-ag
Copy link
Member Author

Hey @jonaslagoni, the usage section is almost complete. Can it also be included in the v3 release if I complete it today?

@jonaslagoni
Copy link
Member

There is nothing special about Modelina v3 so everything fixed before the release will of course be included 🙂 It's a continuous effort to improve the tool so yea 👍

Copy link

Quality Gate Passed Quality Gate passed

Kudos, no new issues were introduced!

0 New issues
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

@devilkiller-ag devilkiller-ag changed the title style(website): redesign hero section style(website): redesign homepage Jan 17, 2024
@devilkiller-ag
Copy link
Member Author

@jonaslagoni I have redesigned the usage section too under this PR!

Copy link
Member

@jonaslagoni jonaslagoni left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks amazing @devilkiller-ag 🔥

@jonaslagoni
Copy link
Member

/rtm

@asyncapi-bot asyncapi-bot merged commit ab59cae into asyncapi:master Jan 18, 2024
19 checks passed
@devilkiller-ag devilkiller-ag deleted the redesign_hero branch January 19, 2024 03:14
@asyncapi-bot
Copy link
Contributor

🎉 This PR is included in version 3.0.0-next.14 🎉

The release is available on:

Your semantic-release bot 📦🚀

@asyncapi-bot
Copy link
Contributor

🎉 This PR is included in version 2.1.2 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants