-
-
Notifications
You must be signed in to change notification settings - Fork 197
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
style(website): redesign homepage #1733
Conversation
✅ Deploy Preview for modelina ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
Pull Request Test Coverage Report for Build 7553458077
💛 - Coveralls |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The code boxes are not scrollable on mobile 🤔
Are you talking about the code boxes in the usage section? I will be working on that section just after this PR. I will most probably change the mobile layout of this section. But for now I will add scrollbar into these code boxes. Or should I do the usage redesign also in this PR? |
Up to you @devilkiller-ag, just let me know when to review again 😄 |
Hey @jonaslagoni, the usage section is almost complete. Can it also be included in the v3 release if I complete it today? |
There is nothing special about Modelina v3 so everything fixed before the release will of course be included 🙂 It's a continuous effort to improve the tool so yea 👍 |
|
@jonaslagoni I have redesigned the usage section too under this PR! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks amazing @devilkiller-ag 🔥
/rtm |
🎉 This PR is included in version 3.0.0-next.14 🎉 The release is available on: Your semantic-release bot 📦🚀 |
🎉 This PR is included in version 2.1.2 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Description
This PR is to redesign the hero of the website as discussed in issue #1293.
Checklist
npm run lint
).npm run test
).