fix: added loading animation

[Gmin2]

Description

Added loading animation

Related Issue

Fixes #1725

Checklist

• [✅] The code follows the project's coding standards and is properly linted (npm run lint).
• Tests have been added or updated to cover the changes.
• Documentation has been updated to reflect the changes.
• All tests pass successfully locally.(npm run test).

[netlify]

❌ Deploy Preview for modelina failed.

Name	Link
🔨 Latest commit	db21f43
🔍 Latest deploy log	https://app.netlify.com/sites/modelina/deploys/65d3273c1be6e20008b006dd

[Gmin2]

@devilkiller-ag @jonaslagoni should i add a animated loading icon ? or this is fine

[coveralls]

Pull Request Test Coverage Report for Build 7957744854

Details

• 0 of 0 changed or added relevant lines in 0 files are covered.
• No unchanged relevant lines lost coverage.
• Overall coverage remained the same at 92.32%

---

Totals
Change from base Build 7957589885:	0.0%
Covered Lines:	5997
Relevant Lines:	6328

---

💛 - Coveralls

[devilkiller-ag]

Hi @Min2who, I can see the loading screen on both the input and output panel (I think this should only be on the output panel cc: @jonaslagoni) only when the website is loaded for the first time, but not when we change any setting. We also want the loading screen (on the output panel only) when we tweak settings.

[Gmin2]

Hi @Min2who, I can see the loading screen on both the input and output panel (I think this should only be on the output panel cc: @jonaslagoni) only when the website is loaded for the first time, but not when we change any setting. We also want the loading screen (on the output panel only) when we tweak settings.

@devilkiller-ag can yu check it one more time the loading screen is only in the output screen only

[devilkiller-ag]

Hi @Min2who, I can see the loading screen on both the input and output panel (I think this should only be on the output panel cc: @jonaslagoni) only when the website is loaded for the first time, but not when we change any setting. We also want the loading screen (on the output panel only) when we tweak settings.

@devilkiller-ag can yu check it one more time the loading screen is only in the output screen only

Here is the screenshot of my inspection. It's showing loading screen on both input editor panel and output panel.

[Gmin2]

Hi @Min2who, I can see the loading screen on both the input and output panel (I think this should only be on the output panel cc: @jonaslagoni) only when the website is loaded for the first time, but not when we change any setting. We also want the loading screen (on the output panel only) when we tweak settings.

@devilkiller-ag can yu check it one more time the loading screen is only in the output screen only

Here is the screenshot of my inspection. It's showing loading screen on both input editor panel and output panel.

@devilkiller-ag this is not because of my changes that i have made
This loading is present in the website only

[jonaslagoni]

Any updates here? 👀

[Gmin2]

Any updates here? 👀

@jonaslagoni can you review the pr .I have added the loading animation on the output screen

[jonaslagoni]

@Min2who all you @devilkiller-ag

[devilkiller-ag]

Hi @Min2who @jonaslagoni, I will review the PR tomorrow as I don't have my laptop with me for now.
@Min2who Can you tick all the checklists in the PR description for then?

[devilkiller-ag]

Hi @Min2who, I can't see the loading animation while changing the options (I used slow 3G network settings). Just to make sure I haven't missed anything can you send a screen recording of the loading animation that you created? Also mark the checkpoints in the PR description, once you feel they are handled correctly.

[devilkiller-ag]

Any updates on this @Min2who?

[Gmin2]

Any updates on this @Min2who?

Playground._.Modelina.-.Google.Chrome.2024-02-01.12-47-17.mp4

[devilkiller-ag]

@Min2who That looks good to me. But don't you think we should also screen-load animation while changing the options 🤔?

2024-02-02.07-54-59.mp4

@jonaslagoni What do you think?

[jonaslagoni]

I agree @devilkiller-ag, its actually part of the issue description ✌️

When you change the input, open the playground, or change the settings, ...

[Gmin2]

@Min2who That looks good to me. But don't you think we should also screen-load animation while changing the options 🤔?

2024-02-02.07-54-59.mp4
@jonaslagoni What do you think?

doing it 🙇‍♂️

[jonaslagoni]

Hey @Min2who have you had a chance to take a look at it? ✌️

[sonarqubecloud]

Quality Gate failed

Failed conditions
4.4% Duplication on New Code (required ≤ 3%)

See analysis details on SonarCloud

[devilkiller-ag]

@jonaslagoni should I close this PR as we have not got any updates from @utnim2 since last two months?

[Gmin2]

I am really sorry for it @jonaslagoni @devilkiller-ag