Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

docs: adding PR Template for modelina #1683

Merged
merged 1 commit into from
Dec 22, 2023
Merged

docs: adding PR Template for modelina #1683

merged 1 commit into from
Dec 22, 2023

Conversation

Harshil-Jani
Copy link
Contributor

Description

  • Helpful for new contributors to consider being aware about lints and tests before rasing the PR and would eventually help better in maintaining the project.

Related issue(s)
Based on discussion raised in #1663

@netlify Netlify
Copy link

netlify bot commented Dec 21, 2023 •
edited
Loading

✅ Deploy Preview for modelina canceled.

Name Link
🔨 Latest commit 15b41b1
🔍 Latest deploy log https://app.netlify.com/sites/modelina/deploys/65860706478223000820d69f

@Harshil-Jani Harshil-Jani changed the title docs: Adding PR Template for modelina docs: adding PR Template for modelina Dec 21, 2023
@coveralls
Copy link

coveralls commented Dec 21, 2023 •
edited
Loading

Pull Request Test Coverage Report for Build 7304157130

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 92.494%
Totals Coverage Status
Change from base Build 7268737994: 0.0%
Covered Lines: 5606
Relevant Lines: 5908
💛 - Coveralls

jonaslagoni
jonaslagoni requested changes Dec 22, 2023
View reviewed changes
Copy link
Member

@jonaslagoni jonaslagoni left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a small suggestion 😄

.github/pull_request_template.md Outdated Show resolved Hide resolved
@Harshil-Jani
docs: Adding PR Template for modelina
15b41b1 
Helpful for new contributors to consider being aware about lints and
tests before rasing the PR and would eventually help better in
maintaining the project.

Signed-off-by: Harshil Jani <harshiljani2002@gmail.com>
@sonarqubecloud SonarQubeCloud
Copy link

Quality Gate Passed Quality Gate passed

Kudos, no new issues were introduced!

0 New issues
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

jonaslagoni
jonaslagoni approved these changes Dec 22, 2023
View reviewed changes
Copy link
Member

@jonaslagoni jonaslagoni left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice 👍

@jonaslagoni jonaslagoni merged commit 1237a8c into asyncapi:master Dec 22, 2023
14 checks passed
@asyncapi-bot
Copy link
Contributor

🎉 This PR is included in version 2.1.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

@asyncapi-bot
Copy link
Contributor

🎉 This PR is included in version 3.0.0-next.11 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jonaslagoni jonaslagoni jonaslagoni approved these changes

@magicmatatjahu magicmatatjahu Awaiting requested review from magicmatatjahu magicmatatjahu is a code owner

@kennethaasan kennethaasan Awaiting requested review from kennethaasan kennethaasan is a code owner

@asyncapi-bot-eve asyncapi-bot-eve Awaiting requested review from asyncapi-bot-eve asyncapi-bot-eve is a code owner

Assignees
No one assigned
Labels
released on @next released
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@Harshil-Jani @coveralls @asyncapi-bot @jonaslagoni