fix: dont render override when the setter doesnt exist in the interface

asyncapi · Sep 6, 2024 · 0b929af · 0b929af
1 parent 0f3fb58
commit 0b929af
Show file tree

Hide file tree

Showing 2 changed files with 23 additions and 3 deletions.
diff --git a/src/generators/java/renderers/ClassRenderer.ts b/src/generators/java/renderers/ClassRenderer.ts
@@ -188,6 +188,28 @@ const isEnumImplementedByConstValue = (
   });
 };
 
+const isEnumOrEnumInExtended = (
+  model: ConstrainedObjectModel,
+  property: ConstrainedObjectPropertyModel
+): boolean => {
+  if (!isEnum(property)) {
+    return false;
+  }
+
+  if (!model.options.extend) {
+    return false;
+  }
+
+  return model.options.extend.some((extend) => {
+    return (
+      extend instanceof ConstrainedReferenceModel &&
+      extend.ref instanceof ConstrainedObjectModel &&
+      extend.ref.properties[property.propertyName] &&
+      isEnum(extend.ref.properties[property.propertyName])
+    );
+  });
+};
+
 export const JAVA_DEFAULT_CLASS_PRESET: ClassPresetType<JavaOptions> = {
   self({ renderer }) {
     return renderer.defaultSelf();
@@ -240,7 +262,7 @@ export const JAVA_DEFAULT_CLASS_PRESET: ClassPresetType<JavaOptions> = {
     }
 
     // don't render override for enums that are set with a const value
-    const override = !isEnumImplementedByConstValue(model, property)
+    const override = !isEnumOrEnumInExtended(model, property)
       ? getOverride(model, property)
       : '';
 

diff --git a/test/generators/java/__snapshots__/JavaGenerator.spec.ts.snap b/test/generators/java/__snapshots__/JavaGenerator.spec.ts.snap
@@ -41,7 +41,6 @@ public interface Pet {
 
   @Override
   public CloudEventDotSequenceType getSequenceType() { return this.sequenceType; }
-  @Override
   public void setSequenceType(CloudEventDotSequenceType sequenceType) { this.sequenceType = sequenceType; }
 
   public String getData() { return this.data; }
@@ -277,7 +276,6 @@ public interface Pet {
 
   @Override
   public CloudEventDotSequenceType getSequenceType() { return this.sequenceType; }
-  @Override
   public void setSequenceType(CloudEventDotSequenceType sequenceType) { this.sequenceType = sequenceType; }
 
   public Map<String, Object> getAdditionalProperties() { return this.additionalProperties; }