Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: switch to the new parser-api #312

Closed
wants to merge 5 commits into from
Closed

feat: switch to the new parser-api #312

wants to merge 5 commits into from

Conversation

magicmatatjahu
Copy link
Member

@magicmatatjahu magicmatatjahu commented Oct 27, 2022 •
edited by fmvilas
Loading

Description

Use new parser-api with v2 ParserJS:

  • update components
  • update tests

Fixes #345

@magicmatatjahu magicmatatjahu added the enhancement New feature or request label Oct 27, 2022
@magicmatatjahu magicmatatjahu marked this pull request as ready for review November 3, 2022 15:05
@sonarqubecloud
Copy link

sonarqubecloud bot commented Nov 3, 2022

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@magicmatatjahu magicmatatjahu changed the title feat: use new parser-api feat: switch to the new parser-api Nov 3, 2022
@magicmatatjahu magicmatatjahu mentioned this pull request Nov 7, 2022
Merged
@github-actions
Copy link

github-actions bot commented Mar 4, 2023

This pull request has been automatically marked as stale because it has not had recent activity 😴

It will be closed in 120 days if no further activity occurs. To unstale this pull request, add a comment with detailed explanation.

There can be many reasons why some specific pull request has no activity. The most probable cause is lack of time, not lack of interest. AsyncAPI Initiative is a Linux Foundation project not owned by a single for-profit company. It is a community-driven initiative ruled under open governance model.

Let us figure out together how to push this pull request forward. Connect with us through one of many communication channels we established here.

Thank you for your patience ❤️

@github-actions github-actions bot added the stale label Mar 4, 2023
@jonaslagoni jonaslagoni mentioned this pull request May 24, 2023
Closed
@jonaslagoni jonaslagoni mentioned this pull request Jun 5, 2023
Closed
2 tasks
@github-actions github-actions bot closed this Jul 2, 2023
@fmvilas fmvilas reopened this Jul 14, 2023
@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 11 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@github-actions github-actions bot removed the stale label Jul 15, 2023
@derberg
Copy link
Member

derberg commented Jul 19, 2023

@magicmatatjahu you have some code smells

@jonaslagoni
Copy link
Member

@magicmatatjahu I am gonna move your implementation along 😄

@jonaslagoni jonaslagoni mentioned this pull request Jul 31, 2023
Merged
@derberg
Copy link
Member

derberg commented Aug 1, 2023

closing and moving to #349

@derberg derberg closed this Aug 1, 2023
@magicmatatjahu magicmatatjahu deleted the new-parser-js branch August 1, 2023 07:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@derberg derberg Awaiting requested review from derberg derberg is a code owner

@fmvilas fmvilas Awaiting requested review from fmvilas fmvilas is a code owner

@asyncapi-bot-eve asyncapi-bot-eve Awaiting requested review from asyncapi-bot-eve asyncapi-bot-eve is a code owner

Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Migrate to new JS parser API
4 participants
@magicmatatjahu @derberg @jonaslagoni @fmvilas