Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

docs: add contributors section with all-contributors bot #223

Merged
merged 8 commits into from
Feb 11, 2022
Merged

docs: add contributors section with all-contributors bot #223

merged 8 commits into from
Feb 11, 2022

Conversation

allcontributors[bot]
Copy link
Contributor

Add @peter-rr as a contributor for code.

This was requested by derberg in this comment

@allcontributors allcontributors bot mentioned this pull request Feb 9, 2022
Merged
derberg
derberg previously approved these changes Feb 9, 2022
View reviewed changes
@derberg derberg changed the title docs: add peter-rr as a contributor for code docs: add contributors section with all-contributors bot Feb 9, 2022
derberg
derberg previously approved these changes Feb 9, 2022
View reviewed changes
Copy link
Member

@derberg derberg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@boyney123 @magicmatatjahu @Souvikns wanna have a look before I merge?

Souvikns
Souvikns previously approved these changes Feb 9, 2022
View reviewed changes
Copy link
Member

@Souvikns Souvikns left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Wow, I see my name 😄.

One quick question, will we have to update the .all-contributorsc file every time a new contributor comes, or will it be automatic.

@magicmatatjahu
Copy link
Member

@derberg LGTM, I will add ideas in the followup to me, and Fran should have also review label.

@magicmatatjahu magicmatatjahu mentioned this pull request Feb 9, 2022
Closed
@derberg derberg dismissed stale reviews from Souvikns and themself via a4bd5e1 February 9, 2022 12:40
@derberg
Copy link
Member

derberg commented Feb 9, 2022

@magicmatatjahu done 👍🏼

@derberg derberg self-requested a review February 9, 2022 12:42
@derberg
Copy link
Member

derberg commented Feb 9, 2022

@Souvikns you need to add folks, it is almost automated but you need to ask bot explicitly. Have a look at https://github.com/asyncapi/.github/blob/master/recognize-contributors.md. You ask bot and bot will open PR for you with updates in proper files

magicmatatjahu
magicmatatjahu approved these changes Feb 9, 2022
View reviewed changes
Copy link
Member

@magicmatatjahu magicmatatjahu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! :)

Souvikns
Souvikns approved these changes Feb 9, 2022
View reviewed changes
Copy link
Member

@Souvikns Souvikns left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚀

@imabp
Copy link
Member

imabp commented Feb 11, 2022

LGTM

@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@Souvikns
Copy link
Member

shall we merge this?

@imabp
Copy link
Member

imabp commented Feb 11, 2022

😆 I will wait for watcher feature to get reviewed and merged by @magicmatatjahu on the latest changes

@derberg
Copy link
Member

derberg commented Feb 11, 2022

/rtm

no need to wait, this is initial PR to introduce contributors section. @magicmatatjahu, once your @imabp PR is merged will use this instruction to ask the bot to add more info about you

@asyncapi-bot asyncapi-bot merged commit ca11ebc into master Feb 11, 2022
@asyncapi-bot asyncapi-bot deleted the all-contributors/add-peter-rr branch February 11, 2022 15:15
@asyncapi-bot
Copy link
Contributor

🎉 This PR is included in version 0.14.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@magicmatatjahu magicmatatjahu magicmatatjahu approved these changes

@Souvikns Souvikns Souvikns approved these changes

@github-actions github-actions[bot] github-actions[bot] approved these changes

@derberg derberg Awaiting requested review from derberg

Assignees
No one assigned
Labels
autoapproved ready-to-merge released
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@magicmatatjahu @derberg @imabp @Souvikns @asyncapi-bot