Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: exit with 1 for failing validations #1068

Merged
merged 4 commits into from
Jan 29, 2024
Merged

fix: exit with 1 for failing validations #1068

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
26c8796
Exit with 1 for failing validations
JarnoRFB Jan 12, 2024
abaee3b
Use process.exitCode
JarnoRFB Jan 16, 2024
b1dc3c4
Merge branch 'master' into fix-validation-exit-code
JarnoRFB Jan 16, 2024
6b2465e
Merge branch 'master' into fix-validation-exit-code
JarnoRFB Jan 29, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 4 additions & 1 deletion src/commands/validate.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -29,6 +29,9 @@ export default class Validate extends Command {
specWatcher({ spec: specFile, handler: this, handlerName: 'validate' });
}

await validate(this, specFile, flags);
const validationResult = await validate(this, specFile, flags);
if (validationResult == 'invalid') {
this.exit(1);
}
}
}
3 changes: 2 additions & 1 deletion test/integration/validate.test.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -117,7 +117,7 @@ describe('validate', () => {
testHelper.setCurrentContext('home');
testHelper.deleteDummyContextFile();
});

test
.stderr()
.stdout()
Expand Down Expand Up @@ -239,6 +239,7 @@ describe('validate', () => {
.stderr()
.stdout()
.command(['validate', './test/fixtures/specification.yml', '--fail-severity=warn'])
.exit(1)
.it('works with --fail-severity', (ctx, done) => {
expect(ctx.stderr).to.include('\nFile ./test/fixtures/specification.yml and/or referenced documents have governance issues.\n\ntest/fixtures/specification.yml');
done();
Expand Down
Loading