feat: adding default file extension for users #117
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fmvilas
requested changes
Nov 3, 2021
Co-authored-by: Fran Méndez <fmvilas@gmail.com>
fmvilas
approved these changes
Nov 9, 2021
|
Kudos, SonarCloud Quality Gate passed!
|
|
Yeah I think this is good to go, I am merging it. |
Souvikns
approved these changes
Nov 10, 2021
|
🎉 This PR is included in version 0.9.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
When user uses the
newcommand they are asked for thefilename.If the user does not provide a file extension the file is created.
This PR will check to see if any file extension has been made, and will add
.yamlonto the filename if no extension has been provided.Why
Just think it's a slightly better developer experience than allowing them to have files without extensions as async API files.
Related issue #114