Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

No file extension when user defines the name of the file (using new command) #114

Closed
boyney123 opened this issue Nov 2, 2021 · 5 comments
Labels
bug Something isn't working enhancement New feature or request good first issue Good for newcomers stale

Comments

@boyney123
Copy link
Contributor

Describe the bug

When user uses the new command they can provide the filename of the file.

For example, if I put myNewFile as a value, the file is created OK, but no file extension is added.

I think it might be a better experience if we detect if no extension is on the file and just put the yaml extension of the file for them?

@boyney123 boyney123 added bug Something isn't working enhancement New feature or request good first issue Good for newcomers labels Nov 2, 2021
@jjung99
Copy link

jjung99 commented Nov 2, 2021

Hi, I would like to take a look at this issue

@boyney123
Copy link
Contributor Author

Hey @jjung99 ,

Sorry I managed to find some time earlier and got a PR raised, but be good if you fancy having a look and review it? #117

Or if you think of a better way to do it?

@jjung99
Copy link

jjung99 commented Nov 2, 2021

It is fine! I just wanted to take a look at others' projects and try to fix a bug if any for learning purposes. Thanks for the comment!

@github-actions
Copy link
Contributor

github-actions bot commented Mar 3, 2022

This issue has been automatically marked as stale because it has not had recent activity 😴

It will be closed in 120 days if no further activity occurs. To unstale this issue, add a comment with a detailed explanation.

There can be many reasons why some specific issue has no activity. The most probable cause is lack of time, not lack of interest. AsyncAPI Initiative is a Linux Foundation project not owned by a single for-profit company. It is a community-driven initiative ruled under open governance model.

Let us figure out together how to push this issue forward. Connect with us through one of many communication channels we established here.

Thank you for your patience ❤️

@github-actions github-actions bot added the stale label Mar 3, 2022
@derberg
Copy link
Member

derberg commented Jun 30, 2022

it is already solved

@derberg derberg closed this as completed Jun 30, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working enhancement New feature or request good first issue Good for newcomers stale
Projects
None yet
Development

No branches or pull requests

3 participants