Refactor builError function to reduce its Cognitive Complexity

asyncapi · Feb 8, 2022 · ca3196f · ca3196f
1 parent e99e4dc
commit ca3196f
Showing 1 changed file with 4 additions and 3 deletions.
diff --git a/src/errors/validation-error.ts b/src/errors/validation-error.ts
@@ -40,18 +40,19 @@ export class ValidationError extends Error {
         // Info added to 'errorsInfo' when both 'e.title' and 'e.location' are available
         if (errorHasTitle && errorHasLocation) {
           errorsInfo.push(`${e.title} ${e.location.startLine}:${e.location.startColumn}`);
+          continue;
         } 
         // Info added to 'errorsInfo' when only 'e.title' is available
-        if (errorHasTitle && !errorHasLocation) {
+        if (errorHasTitle) {
           errorsInfo.push(`${e.title}`);
+          continue;
         }
         // Info added to 'errorsInfo' when only 'e.location' is available
-        if (!errorHasTitle && errorHasLocation) {
+        if (errorHasLocation) {
           errorsInfo.push(`${e.location.startLine}:${e.location.startColumn}`);
         }
       }
     }
-
     this.message = errorsInfo.join('\n');
   }
 }