Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: resolve external references in base file #102

Merged
merged 1 commit into from
Nov 29, 2022

Conversation

Souvikns
Copy link
Member

Description
A small fix for asyncapi/cli#391, the external references from the base file were not being resolved, This PR adds -

  • external reference resolution for base file
  • tests for base file file usage.

Related issue(s)

Fixes #101

@aeworxet
Copy link
Collaborator

Jest test in Bundler's repository was passing both WITHOUT and WITH the proposed change, so the CLI repository had to be used.

In root of CLI repository executed

$ npm run build

then ran

$ ./bin/run bundle ./test/commands/bundle/asyncapi.yaml ./test/commands/bundle/spec.yaml --reference-into-components -b ./test/commands/bundle/asyncapi.yaml -o ./test/commands/bundle/main.yaml

Visual diff of the code WITHOUT and WITH proposed change:

image

@aeworxet
Copy link
Collaborator

/rtm

@asyncapi-bot
Copy link
Contributor

Hello, @aeworxet! 👋🏼
This PR is not up to date with the base branch and can't be merged.
Please update your branch manually with the latest version of the base branch.
PRO-TIP: Add a comment to your PR with the text: /au or /autoupdate and our bot will take care of updating the branch in the future. The only requirement for this to work is to enable Allow edits from maintainers option in your PR.
Thanks 😄

@aeworxet
Copy link
Collaborator

/autoupdate

@aeworxet aeworxet merged commit b4a0224 into asyncapi:master Nov 29, 2022
@asyncapi-bot
Copy link
Contributor

🎉 This PR is included in version 0.3.8 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

base options not working as intended
3 participants