Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat!: upgrade to react v18 #998

Merged
merged 6 commits into from
Apr 29, 2024
Merged

Conversation

kennethaasan
Copy link
Contributor

@kennethaasan kennethaasan commented Apr 24, 2024

Description

Changes proposed in this pull request:

Related issue(s)

See also #891

@kennethaasan kennethaasan marked this pull request as ready for review April 24, 2024 10:55
@derberg
Copy link
Member

derberg commented Apr 25, 2024

@kennethaasan one tiny merge conflict because of #995

Copy link

sonarcloud bot commented Apr 25, 2024

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

@kennethaasan
Copy link
Contributor Author

@derberg, should be fixed now.

@derberg
Copy link
Member

derberg commented Apr 25, 2024

and you checked and playground still works after upgrade? 😄

@kennethaasan
Copy link
Contributor Author

@derberg, yes, playground works and the library seems to work just fine :)

@derberg derberg changed the title feat!: upgrades react to v18 feat!: upgrade to react v18 Apr 29, 2024
@derberg
Copy link
Member

derberg commented Apr 29, 2024

/rtm

@asyncapi-bot asyncapi-bot merged commit 6f6b8bd into asyncapi:master Apr 29, 2024
13 checks passed
@asyncapi-bot
Copy link
Contributor

🎉 This PR is included in version 2.0.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants