feat: update openapi-sampler to 1.0.0 for better examples generation

[magicmatatjahu]

Description

Changes proposed in this pull request:

Update openapi-sampler package to 1.0.0. Support for more type formats and JSON Schema 7 driven by support for OpenAPI 3.1.
Changes: Redocly/openapi-sampler#122

Displaying time format:

Related issue(s)
Part of #209

[sonarcloud]

Kudos, SonarCloud Quality Gate passed!

0 Bugs
0 Vulnerabilities
0 Security Hotspots
0 Code Smells

No Coverage information
No Duplication information

[derberg]

@magicmatatjahu I took the liberty to extend description a bit and the PR title too.

You need to change to merge into master and not next

[magicmatatjahu]

@derberg Thanks! I described why it must be done in two separate PRs here -> #352 (comment) It's related to changes in package-lock between master and next branches. If I will make cherrypick from master to next then I will have to fixing rebase issues.

[derberg]

@magicmatatjahu sorry but I didn't get it. what is the problem to put it into master, then merge master into next? even if there are differences with conflicts, then just resolve by saying what is in next is priority, then npm install to add updated openapi-sampler to package-lock. Or am I missing something?

[magicmatatjahu]

Then you will have two different commits if you will change something from cherry picking, yes? It will only complicate topic, really.

[derberg]

Do you mean cherry-picking as a concept or as a git functionality? why not just do a simple merge of latest master into next? I don't think there is anything in the master that cannot be pulled into next, right? this means normal PR, with as many commits you want and then squashing and merging into next as a single commit, right?

[derberg]

🤦🏼 I think now I get it, of course you need to do cherry pick, you are right that 2 separate PRs to next and master are better. Awaiting for a PR to master then

[magicmatatjahu]

why not just do a simple merge of latest master into next? I don't think there is anything in the master that cannot be pulled into next, right?

No, there are a lot of changes between master and next branches. As I remember some dependencies also was removed from next branches in unification time. Really, don't complicated topic in this area. We will have to merge master to next in some time, when we will decide to go finally with 1.0.0, but it's not worth the trouble for just one package.

[magicmatatjahu]

@derberg Thanks a lot for patience ❤️

[derberg]

@magicmatatjahu remember about it once we see each other in a bar 🍻 😆

[asyncapi-bot]

🎉 This PR is included in version 1.0.0-next.4 🎉

The release is available on:

• npm package (@next dist-tag)
• GitHub release

Your semantic-release bot 📦🚀