Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: rewritten Info component #277

Merged
merged 1 commit into from
Mar 25, 2021

Conversation

aeworxet
Copy link
Contributor

This PR brings React component's playground appearance closer to playground.asyncapi.io's.
Unification process is in progress, CSS styles will be polished further.

@magicmatatjahu magicmatatjahu added area/library Related to all activities around Library package enhancement New feature or request labels Mar 25, 2021
Copy link
Member

@magicmatatjahu magicmatatjahu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome! Only two suggestions! :)

library/src/components/Markdown.tsx Outdated Show resolved Hide resolved
library/src/containers/Info/NewInfo.tsx Outdated Show resolved Hide resolved
@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@aeworxet aeworxet requested a review from magicmatatjahu March 25, 2021 10:09
Copy link
Member

@magicmatatjahu magicmatatjahu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome! Thanks for contribution :)

@magicmatatjahu magicmatatjahu merged commit 3d7c733 into asyncapi:unify-component Mar 25, 2021
@aeworxet aeworxet deleted the unify-component branch March 25, 2021 14:38
@asyncapi-bot
Copy link
Contributor

🎉 This PR is included in version 0.21.0-next.1 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/library Related to all activities around Library package enhancement New feature or request released on @next
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants