-
Notifications
You must be signed in to change notification settings - Fork 63
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ci: upgrade some actions related to planned GH deprecations #226
Conversation
cc @KhudaDad414 please review 🙏🏼 not an easy one cc @14Richa would be cool if you could this time contribute as reviewer 🙏🏼 cc @saurav9878 maybe you wanna have a look |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! left some comments.
@@ -14,11 +14,13 @@ jobs: | |||
name: Slack - notify on every release | |||
runs-on: ubuntu-latest | |||
steps: | |||
- name: Checkout repository |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What is the point of these checkouts? I assume it is because of asyncapi/.github/.github/actions/slackify-markdown@master
, but why?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
yeah, they are actually not needed, good 🦅 👁️
checkout was needed as I could not figure out how to get these new types of actions from the remote repository, so idea was to replicate it and therefore checkout was needed to run them
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
it is actually needed, because the new composite action installs some dependencies, and I use cache there, and it needs to update cache somewhere, so basically without checkout this action fails
Co-authored-by: Khuda Dad Nomani <32505158+KhudaDad414@users.noreply.github.com>
actions bumps forced by node12 -> node16:
actions/checkout@v3
. It is safe as they bumped from v2 to v3 only to upgrade the node runner to node 16. No breaking changesactions/github-script@v6
. There were breaking changes in v5 only, v6 was just node engine update. Only one workflow needed a refactor togithub.rest
pascalgn/automerge-action
. No breaking changes, just for node engine deprecationhmarr/auto-approve-action
. No breaking changes, just for node engine deprecationif-docker-pr-testing.yml
workflow. No breaking changes, just for node engine deprecationif-go-pr-testing.yml
workflow. No breaking changes, just for node engine deprecationactions/setup-node
to v3. Node engine related. There is one breaking change that do not relate to us, to usenode-version
input instead ofversion
- but that was always donepeter-evans/create-pull-request
. There are some breaking changes related toadd-paths
but we are no using it. We need to upgrade because of node engingeamannn/action-semantic-pull-request
because of node.marocchino/sticky-pull-request-comment
- nodederberg/npm-dependency-manager-for-your-github-org
- nodem1ner79/Github-Twittction
-noderemoval of one action
Remove
sentiment-analysis.yml
- it will not work because of node deprecation. The fact is that this action is not working for few months already, it was never good because of lack of context and was 100% of time causing false positivesstop using
actions-ecosystem/action-create-comment
Looks like
actions-ecosystem/action-create-comment
is not maintained and they did not bump version for node16. I removed it fromhelp-command.yml
and now use GitHub API directly in script actionstop using
LoveToKnow/slackify-markdown-action
Unfortunately
LoveToKnow/slackify-markdown-action
is not very much maintained and there is a PR to change to node16 for months, not merged.Now we do not use this action but for the first time we will use composite action -> https://github.com/asyncapi/.github/pull/226/files#diff-dacdba02324430e1c58a8c5262cf680d96abfc8ca95a5b3500cc9aa9ef10d155
I'm personally in love with composite actions and think we can optimize our CI with it a lot. Important to notice there composite actions do not have to be replicated with global workflow in multiple repos, can be referenced from this repo
this was tested in my test repo:
refactor
set-output
set-output
goes away -> https://github.blog/changelog/2022-10-11-github-actions-deprecating-save-state-and-set-output-commands/so they had to be refactored to a new way