This repository has been archived by the owner on Apr 11, 2024. It is now read-only.
feat: encode ws messages to json so they become machine-readable #28
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
smoya
force-pushed
the
feat/machine-readable-logs
branch
from
d830016 to
7c3ed25
Compare
smoya
commented
Aug 16, 2021
| @@ -50,7 +50,6 @@ func main() { | |||
| }) | |||
|
|
|||
| r := chi.NewRouter() | |||
| r.Get("/", http.FileServer(http.Dir("./web/static")).ServeHTTP) | |||
There was a problem hiding this comment.
This wasn't suppose to be there 😅
fmvilas
approved these changes
Aug 19, 2021
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR changes the way validation errors are encoded and then sent to the WS connection. In particular, it encodes each WS message to JSON so it can become machine-readable. This is useful for automating end-to-end tests on real infrastructure.
An example of an encoded WS message (formatted):
{ "ts": "2021-08-16T12:36:12.025941+02:00", "msg": { "context": { "channel": "demo" }, "key": "c21veWEtd2FzLWhlcmU=", "value": "eyJjb21tYW5kIjogMX0=" }, "errors": [ "command: Invalid type. Expected: string, given: integer" ] }Related issue(s)
#23