Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix ambiguous import on standalone helper components (fixes #72) #73

Merged
merged 9 commits into from
Aug 9, 2019

Conversation

ghengeveld
Copy link
Member

@ghengeveld ghengeveld commented Aug 6, 2019

Description

This resolves an issue with ambiguous imports, where helpers such as Fulfilled clash with React.Fulfilled. The solution is to rename all helper components to IfX, e.g. IfFulfilled.

This also fixes #72 the TypeScript definitions for helper components.

Breaking changes

All helper components are renamed without backwards compatibility. To upgrade:

  • replace <Initial with <IfInitial
  • replace <Pending with <IfPending
  • replace <Fulfilled with <IfFulfilled
  • replace <Rejected with <IfRejected
  • replace <Settled with <IfSettled

Checklist

Make sure you check all the boxes. You can omit items that are not applicable.

  • Added / updated the unit tests
  • Added / updated the documentation
  • Updated the PropTypes
  • Updated the TypeScript type definitions

@codecov
Copy link

codecov bot commented Aug 7, 2019

Codecov Report

Merging #73 into master will not change coverage.
The diff coverage is 100%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master      #73   +/-   ##
=======================================
  Coverage   99.28%   99.28%           
=======================================
  Files           9        9           
  Lines         703      703           
  Branches      158      158           
=======================================
  Hits          698      698           
  Misses          5        5
Impacted Files Coverage Δ
packages/react-async/src/Async.js 100% <100%> (ø) ⬆️
packages/react-async/src/helpers.js 100% <100%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 839ff17...8f61a92. Read the comment docs.

@ghengeveld ghengeveld changed the title Fix ambiguous import on standalone helper components Fix ambiguous import on standalone helper components (fixes #72) Aug 8, 2019
@ghengeveld
Copy link
Member Author

This branch was just published as 8.0.0-alpha.0 and can be installed via react-async@next.

@ghengeveld ghengeveld merged commit 5bed28d into master Aug 9, 2019
@ghengeveld
Copy link
Member Author

Released in v8.0.0

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

TypeScript defs for Helper Functions with Hooks
1 participant