Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Winston bug #130

Closed
YuriGor opened this issue Sep 30, 2018 · 10 comments
Closed

Winston bug #130

YuriGor opened this issue Sep 30, 2018 · 10 comments
Assignees
@tima101
Labels
code inside book Ready to test - Async Issue is implemented and ready for testing. PR is merged.

Comments

@YuriGor
Copy link
Contributor

YuriGor commented Sep 30, 2018 •
edited by tima101
Loading

Just to save someone's time, there is a bug in Winston
preventing from logging email template correctly
message field will be swallowed
Could you please recommend any other logger lib? There are so many unresolved issues in the Winston..

Click to see Hill for issue #130
Single issue hill
Click to see Hill for all issues
All issue hill

created by Async
@tima101 tima101 self-assigned this Oct 2, 2018
@YuriGor
Copy link
Contributor Author

YuriGor commented Oct 5, 2018

Problem is much wider:
Winston cuts Errror's message and stacktrace when using logger.error, so there is no way to debug SES for example.
I wasted a lot of time before switched back to console.error finally.

@tima101
Copy link
Member

tima101 commented Oct 5, 2018

@YuriGor What about logger.debug?

@YuriGor
Copy link
Contributor Author

YuriGor commented Oct 5, 2018 via email •
edited
Loading

@YuriGor YuriGor mentioned this issue Oct 12, 2018
Closed
@tima101
Copy link
Member

tima101 commented Oct 23, 2018

Adding note to myself: winstonjs/winston#1510

@YuriGor
Copy link
Contributor Author

YuriGor commented Dec 27, 2018

According to the most recent reply we need to adjust Winston config for fixing this issue.

@tima101
Copy link
Member

tima101 commented Dec 28, 2018 •
edited
Loading

@YuriGor Thanks as always. Yeah, I saw the fix, on my todo list. Will do before the end of 2018.

tima101 added a commit that referenced this issue Jan 18, 2019
@tima101
#130: winston bug
dcd5f00
@tima101 tima101 added Downhill - Async Issue is being actively implemented, interruptions are discouraged. PR is under review. Ready to test - Async Issue is implemented and ready for testing. PR is merged. and removed Downhill - Async Issue is being actively implemented, interruptions are discouraged. PR is under review. labels Jan 18, 2019
@tima101
Copy link
Member

tima101 commented Jan 18, 2019

@YuriGor Fixed: c##130: winston bug

tima101 added a commit that referenced this issue Jan 24, 2019
@tima101
#130: winston bug
ab55bcd
@tima101
Copy link
Member

tima101 commented Jan 24, 2019 •
edited
Loading

@delgermurun @klyburke @YuriGor merged to master and updated book's text

@YuriGor
Copy link
Contributor Author

YuriGor commented Jan 25, 2019

Perfect. Do you need me to test the changes first (i have no time right in the moment) or i can close this issue?

@tima101
Copy link
Member

tima101 commented Jan 25, 2019

@YuriGor I tested. Please close the issue. Thanks for reporting it.

@YuriGor YuriGor closed this as completed Jan 25, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@tima101 tima101

Labels
code inside book Ready to test - Async Issue is implemented and ready for testing. PR is merged.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@YuriGor @tima101