Differentiate empty list to not set list (#668)

async-aws · Jun 9, 2020 · e6eb162 · e6eb162
1 parent ca24099
commit e6eb162
Show file tree

Hide file tree

Showing 4 changed files with 38 additions and 29 deletions.
diff --git a/src/Input/GetParametersByPathRequest.php b/src/Input/GetParametersByPathRequest.php
@@ -31,7 +31,7 @@ final class GetParametersByPathRequest extends Input
     /**
      * Filters to limit the request results.
      *
-     * @var ParameterStringFilter[]
+     * @var ParameterStringFilter[]|null
      */
     private $ParameterFilters;
 
@@ -72,7 +72,7 @@ public function __construct(array $input = [])
     {
         $this->Path = $input['Path'] ?? null;
         $this->Recursive = $input['Recursive'] ?? null;
-        $this->ParameterFilters = array_map([ParameterStringFilter::class, 'create'], $input['ParameterFilters'] ?? []);
+        $this->ParameterFilters = isset($input['ParameterFilters']) ? array_map([ParameterStringFilter::class, 'create'], $input['ParameterFilters']) : null;
         $this->WithDecryption = $input['WithDecryption'] ?? null;
         $this->MaxResults = $input['MaxResults'] ?? null;
         $this->NextToken = $input['NextToken'] ?? null;
@@ -99,7 +99,7 @@ public function getNextToken(): ?string
      */
     public function getParameterFilters(): array
     {
-        return $this->ParameterFilters;
+        return $this->ParameterFilters ?? [];
     }
 
     public function getPath(): ?string
@@ -197,13 +197,14 @@ private function requestBody(): array
         if (null !== $v = $this->Recursive) {
             $payload['Recursive'] = (bool) $v;
         }
-
-        $index = -1;
-        foreach ($this->ParameterFilters as $listValue) {
-            ++$index;
-            $payload['ParameterFilters'][$index] = $listValue->requestBody();
+        if (null !== $v = $this->ParameterFilters) {
+            $index = -1;
+            $payload['ParameterFilters'] = [];
+            foreach ($v as $listValue) {
+                ++$index;
+                $payload['ParameterFilters'][$index] = $listValue->requestBody();
+            }
         }
-
         if (null !== $v = $this->WithDecryption) {
             $payload['WithDecryption'] = (bool) $v;
         }

diff --git a/src/Input/GetParametersRequest.php b/src/Input/GetParametersRequest.php
@@ -2,6 +2,7 @@
 
 namespace AsyncAws\Ssm\Input;
 
+use AsyncAws\Core\Exception\InvalidArgument;
 use AsyncAws\Core\Input;
 use AsyncAws\Core\Request;
 use AsyncAws\Core\Stream\StreamFactory;
@@ -13,7 +14,7 @@ final class GetParametersRequest extends Input
      *
      * @required
      *
-     * @var string[]
+     * @var string[]|null
      */
     private $Names;
 
@@ -34,7 +35,7 @@ final class GetParametersRequest extends Input
      */
     public function __construct(array $input = [])
     {
-        $this->Names = $input['Names'] ?? [];
+        $this->Names = $input['Names'] ?? null;
         $this->WithDecryption = $input['WithDecryption'] ?? null;
         parent::__construct($input);
     }
@@ -49,7 +50,7 @@ public static function create($input): self
      */
     public function getNames(): array
     {
-        return $this->Names;
+        return $this->Names ?? [];
     }
 
     public function getWithDecryption(): ?bool
@@ -102,9 +103,13 @@ public function setWithDecryption(?bool $value): self
     private function requestBody(): array
     {
         $payload = [];
+        if (null === $v = $this->Names) {
+            throw new InvalidArgument(sprintf('Missing parameter "Names" for "%s". The value cannot be null.', __CLASS__));
+        }
 
         $index = -1;
-        foreach ($this->Names as $listValue) {
+        $payload['Names'] = [];
+        foreach ($v as $listValue) {
             ++$index;
             $payload['Names'][$index] = $listValue;
         }

diff --git a/src/Input/PutParameterRequest.php b/src/Input/PutParameterRequest.php
@@ -77,7 +77,7 @@ final class PutParameterRequest extends Input
      * type of resource to which it applies, the environment, or the type of configuration data referenced by the parameter.
      * In this case, you could specify the following key name/value pairs:.
      *
-     * @var Tag[]
+     * @var Tag[]|null
      */
     private $Tags;
 
@@ -128,7 +128,7 @@ public function __construct(array $input = [])
         $this->KeyId = $input['KeyId'] ?? null;
         $this->Overwrite = $input['Overwrite'] ?? null;
         $this->AllowedPattern = $input['AllowedPattern'] ?? null;
-        $this->Tags = array_map([Tag::class, 'create'], $input['Tags'] ?? []);
+        $this->Tags = isset($input['Tags']) ? array_map([Tag::class, 'create'], $input['Tags']) : null;
         $this->Tier = $input['Tier'] ?? null;
         $this->Policies = $input['Policies'] ?? null;
         $this->DataType = $input['DataType'] ?? null;
@@ -180,7 +180,7 @@ public function getPolicies(): ?string
      */
     public function getTags(): array
     {
-        return $this->Tags;
+        return $this->Tags ?? [];
     }
 
     /**
@@ -344,13 +344,14 @@ private function requestBody(): array
         if (null !== $v = $this->AllowedPattern) {
             $payload['AllowedPattern'] = $v;
         }
-
-        $index = -1;
-        foreach ($this->Tags as $listValue) {
-            ++$index;
-            $payload['Tags'][$index] = $listValue->requestBody();
+        if (null !== $v = $this->Tags) {
+            $index = -1;
+            $payload['Tags'] = [];
+            foreach ($v as $listValue) {
+                ++$index;
+                $payload['Tags'][$index] = $listValue->requestBody();
+            }
         }
-
         if (null !== $v = $this->Tier) {
             if (!ParameterTier::exists($v)) {
                 throw new InvalidArgument(sprintf('Invalid parameter "Tier" for "%s". The value "%s" is not a valid "ParameterTier".', __CLASS__, $v));

diff --git a/src/ValueObject/ParameterStringFilter.php b/src/ValueObject/ParameterStringFilter.php
@@ -34,7 +34,7 @@ public function __construct(array $input)
     {
         $this->Key = $input['Key'] ?? null;
         $this->Option = $input['Option'] ?? null;
-        $this->Values = $input['Values'] ?? [];
+        $this->Values = $input['Values'] ?? null;
     }
 
     public static function create($input): self
@@ -57,7 +57,7 @@ public function getOption(): ?string
      */
     public function getValues(): array
     {
-        return $this->Values;
+        return $this->Values ?? [];
     }
 
     /**
@@ -73,11 +73,13 @@ public function requestBody(): array
         if (null !== $v = $this->Option) {
             $payload['Option'] = $v;
         }
-
-        $index = -1;
-        foreach ($this->Values as $listValue) {
-            ++$index;
-            $payload['Values'][$index] = $listValue;
+        if (null !== $v = $this->Values) {
+            $index = -1;
+            $payload['Values'] = [];
+            foreach ($v as $listValue) {
+                ++$index;
+                $payload['Values'][$index] = $listValue;
+            }
         }
 
         return $payload;