Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add ner spacy #11

Merged
merged 13 commits into from
May 10, 2021
Merged

Add ner spacy #11

merged 13 commits into from
May 10, 2021

Conversation

jennyzhang-petuum
Copy link
Collaborator

@jennyzhang-petuum jennyzhang-petuum commented Apr 6, 2021

This PR fixes #10 and fixes #22 .

Description of changes

Added ner as an option in the config so that spacy processor could choose whether ner prediction would be done or not.

@hunterhector
Copy link
Member

looks good, do we need to merge #5 before this?

Copy link
Member

@hunterhector hunterhector left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

need to call super

forte_wrapper/nltk/nltk_processors.py Show resolved Hide resolved
@@ -68,6 +73,10 @@ class NLTKLemmatizer(PackProcessor):
r"""A wrapper of NLTK lemmatizer.
"""

# pylint: disable=unused-argument
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

call the superclass initialize function and remove the pylint disable.

@hunterhector hunterhector merged commit ff27e77 into asyml:main May 10, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants