Minor improvements on AstelcoDome. #52
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…hen in stand mode.
| 'ahost': 'localhost', | ||
| 'aport': "65432"} | ||
| "maxidletime": 90., | ||
| "stabilization_time": 5.} |
There was a problem hiding this comment.
This config statement is wrong. You finish the dict, but put 2 lines more.
| @@ -231,8 +263,6 @@ def open(self): | |||
| print self._tpl.getobject('SERVER.UPTIME') | |||
| self._tpl | |||
There was a problem hiding this comment.
L260, 262 and 264 are useless.
|
Thanks for doing the suggested changes. Since that this works with our ASTELCO telescope in Chile and this PR only affects the astelcodome.py. I suggest to merge it. |
|
Looks good to me. |
wschoenell
added a commit
that referenced
this pull request
May 4, 2015
|
Merged #52. |
|
On Mon, May 4, 2015 at 6:05 PM, Paulo Henrique Silva <
|
wschoenell
added a commit
to wschoenell/chimera
that referenced
this pull request
Jun 29, 2015
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add move to azimuth, to move the dome when in stand mode. It also fixes indentation to comply with PEP8.