Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Compromise and print out the estimated parameters individually #1159

Merged
merged 1 commit into from
Aug 8, 2024

Conversation

rosteen
Copy link
Contributor

@rosteen rosteen commented Aug 8, 2024

Trying to fix the annoying Mac doctest failure (which I can't replicate on my own Mac...)

Fixes #1146

@rosteen rosteen added this to the v1.x milestone Aug 8, 2024
@rosteen rosteen marked this pull request as ready for review August 8, 2024 20:29
Copy link
Member

@pllim pllim left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works for me. Thanks!

@pllim
Copy link
Member

pllim commented Aug 8, 2024

Since there is nothing you can do about the deprecation warning in devdeps, maybe you just want to ignore it?

Copy link

codecov bot commented Aug 8, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 86.88%. Comparing base (b59003e) to head (043a5c1).

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #1159   +/-   ##
=======================================
  Coverage   86.88%   86.88%           
=======================================
  Files          63       63           
  Lines        4544     4544           
=======================================
  Hits         3948     3948           
  Misses        596      596           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@rosteen
Copy link
Contributor Author

rosteen commented Aug 8, 2024

Since there is nothing you can do about the deprecation warning in devdeps, maybe you just want to ignore it?

Eh, it's an allowed failure, I'm inclined to leave it as-is for now. I don't want to forget about it in case it actually starts causing problems later on...

@rosteen rosteen merged commit 3eb717d into astropy:main Aug 8, 2024
13 of 14 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

TST: a failing doctest on MacOS + numpy 2
2 participants