Ensure arithmetic results preserve spectral axis shifts #1158
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1131. We outsource most of the arithmetic logic to the inherited upstream handling, but it seems that wasn't preserving the outcome of
shift_spectrum_to
for some reason. I don't fully understand how the results were ending up with the original spectral axis, since that method updatesself._spectral_axis
, but this workaround is sufficient to give the expected behavior for now.