-
-
Notifications
You must be signed in to change notification settings - Fork 66
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Allow single inputs to find_optimal_celestial_wcs and add ability to specify HDU #344
Allow single inputs to find_optimal_celestial_wcs and add ability to specify HDU #344
Conversation
…and add ability to pass in hdu_in for FITS files and HDULists
Codecov Report
@@ Coverage Diff @@
## main #344 +/- ##
==========================================
- Coverage 92.62% 92.39% -0.23%
==========================================
Files 24 24
Lines 786 802 +16
==========================================
+ Hits 728 741 +13
- Misses 58 61 +3
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
49eb575
to
cb2729f
Compare
Once this is merged we can set up a similar fixture for output projections and add support for APE 14 shapes |
If only one input data needs to be provided, it is also possible to | ||
pass it in without including it in an iterable. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is the added complexity really worth this?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Absolutely 😄
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good for a quick look to me
input_value = (array, wcs) | ||
elif request.param == "nddata": | ||
input_value = NDData(data=array, wcs=wcs) | ||
elif request.param == "ape14_wcs": |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is in this elif twice?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Fixed
Co-authored-by: Stuart Mumford <stuart@cadair.com>
Still to do:
shape_out
optional if input WCS hasarray_shape
#309)Fixes #323