Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement CircleSectorPixelRegion #486

Draft
wants to merge 6 commits into
base: main
Choose a base branch
from

Conversation

adonath
Copy link
Member

@adonath adonath commented Oct 27, 2022

This PR is a draft to implement a CircleSectorPixelRegion. I needed this for a specific analysis, so I decided to just implement it. Here is a notebook to illustrate that the bounding box and contains methods work correctly for all quadrants https://github.com/adonath/notebooks-public/blob/master/circle_sector_pix_region_illustration.ipynb

Some ToDos:

  • Implement a CircleSectorSkyRegion
  • Implement CircleSectorPixelRegion.to_sky()
  • Implement CircleSectorPixelRegion.to_mask()

@adonath adonath changed the title Implement CircleSectorPixRegion Implement CircleSectorPixelRegion Oct 27, 2022
@adonath
Copy link
Member Author

adonath commented Aug 1, 2024

@larrybradley is this a desired feature? Are there any guidelines with respect to adding new shapes to regions?

@larrybradley
Copy link
Member

@adonath This looks like a nice addition to me! Implementing the "exact" mode for exact partial pixel overlaps could be tricky.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants