MAINT: minor fixes to setup.cfg and MANIFEST #371
Conversation
Codecov Report
@@ Coverage Diff @@
## main #371 +/- ##
=======================================
Coverage 78.55% 78.55%
=======================================
Files 47 47
Lines 5564 5564
=======================================
Hits 4371 4371
Misses 1193 1193 📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
|
There is only one expected linter error due to #378. I expect the fix for that bug is trivial and quick, so I didn't apply any workarounds for it in this set of linter fixes. |
bsipocz
force-pushed
the
MAINT_manifest_and_setup
branch
2 times, most recently
from
dca29ac to
677ce0b
Compare
bsipocz
force-pushed
the
MAINT_manifest_and_setup
branch
from
a39a756 to
d82bb9a
Compare
| @@ -165,20 +164,20 @@ def test_mirrors_parsed(self, parsed_caps): | |||
|
|
|||
| def test_mirrors_have_titles(self, parsed_caps): | |||
| assert [m.title for m in parsed_caps[3].interfaces[0].mirrorurls | |||
| ] == ["https version", "Paris mirror"] | |||
| ] == ["https version", "Paris mirror"] | |||
There was a problem hiding this comment.
For these I would have closed the bracket in the row above.
pyvo/registry/tests/test_rtcons.py
Outdated
| assert rtcons.Freetext("α Cen's planets").get_search_condition() == ( | ||
| "ivoid IN (SELECT ivoid FROM rr.resource WHERE 1=ivo_hasword(res_description, 'α Cen''s planets')" | ||
| " UNION SELECT ivoid FROM rr.resource WHERE 1=ivo_hasword(res_title, 'α Cen''s planets') " | ||
| "UNION SELECT ivoid FROM rr.res_subject WHERE res_subject ILIKE '%α Cen''s planets%')") |
There was a problem hiding this comment.
nitpicking - consistency in whitespaces in front of 'UNION`
pyvo/registry/tests/test_rtcons.py
Outdated
| return rtcons.build_regtap_query(cons | ||
| ).split("\nWHERE\n", 1)[1].split("\nGROUP BY\n")[0] | ||
| ).split("\nWHERE\n", 1)[1].split("\nGROUP BY\n")[0] |
There was a problem hiding this comment.
The new line seems mispositioned IMO.
yep, used autopep8 which took care of most of the things, and then I touched up the remaining ones manually. |
This will close #302 and also clears up the inconsistency between code and docs line length.