-
-
Notifications
You must be signed in to change notification settings - Fork 401
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Download Products with MastMissions #3155
Open
snbianco
wants to merge
8
commits into
astropy:main
Choose a base branch
from
snbianco:ASB-29334-download-missions
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #3155 +/- ##
==========================================
+ Coverage 67.54% 67.74% +0.20%
==========================================
Files 233 233
Lines 18493 18634 +141
==========================================
+ Hits 12491 12624 +133
- Misses 6002 6010 +8 ☔ View full report in Codecov by Sentry. |
Tagging @astrojimig and @dr-rodriguez for visibility |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This MR adds methods to
MastMissions
that allow users to retrieve and download products from the Missions-MAST API.get_product_list
get_unique_product_list
filter_products
download_products
download_file
A few notes:
mission
property so that users can use the sameMastMissions
object to query multiple missions.dataset_kwds
and_default_ullyses_cols
, for example). These are due to limitations in the API, and I've reported these problems internally at MAST.missions_request_async
function toservices.py
to handle API requests coming fromMastMissions
.