Partial rewrite of the MOCServer module

[ManonMarchand]

Hello astroquery,

This is a quite big rewrite of the MOS Server module.

The two main motivations behind it were:

• there was a bug that using query_region with a MOC would write a real file on the people's current folder. This file would be named moc.fits and could potentially overwrite a pre-existing file with the same name silently.
• the MOC server upstream now works with time MOCs and space-time MOCs, so these features were needed here

The actual changes in this PR

• new method query_hips allows to filter only hips in a shortcut rather than having to remember all the time to have to type hips_frame=* in the meta_data (convenience method)
• before, you could only search by region or by meta_data. This was unnecessary, and now the two methods are exactly the same and allow to filter on region and to add a criteria. I was wondering whether find_datasets should be deprecated
• new parameters casesensitive and spacesys allow to chose whether the query will respect the case, and to chose a specific system for the datasets (ex: mars, venus, sky)
• new methods list_spacesys that prints the currently available spacesys (can evolve as providers post new datasets)
• new method list_fields to see the possible fields (there are 134 today) sorted by occurrence and with an example
• the default returned table now have a sub-selection of fields rather than the whole 134 ones (this speeds up the module considerably)
• return_moc is no longer only a boolean. It keeps it former behavior (True means Space MOC) but it can now also take the values smoc, tmoc, or stmoc to specify the kind of MOC that should be returned
• in query_region, the region argument can now also be a mocpy.TimeMOC and a mocpy.STMOC on top of the previously accepted classes
• removed the regions module from the mandatory dependencies

Changes while I was there

• doctesting turned on in the documentation (one box to tick in Enable doctesting for all narrative documentations #2935 )
• remove the **kwargs arguments in all the methods

[pep8speaks]

Hello @ManonMarchand! Thanks for updating this PR. We checked the lines you've touched for PEP 8 issues, and found:

There are currently no PEP 8 issues detected in this Pull Request. Cheers! 🍻

Comment last updated at 2024-12-19 13:33:05 UTC

[codecov]

Codecov Report

Attention: Patch coverage is 92.59259% with 8 lines in your changes missing coverage. Please review.

Project coverage is 67.69%. Comparing base (04c6069) to head (804c94a).
Report is 10 commits behind head on main.

Files with missing lines	Patch %	Lines
astroquery/mocserver/core.py	92.52%	8 Missing ⚠️

Additional details and impacted files

@@            Coverage Diff             @@
##             main    #3139      +/-   ##
==========================================
+ Coverage   67.54%   67.69%   +0.14%     
==========================================
  Files         233      233              
  Lines       18493    18476      -17     
==========================================
+ Hits        12491    12507      +16     
+ Misses       6002     5969      -33     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[ManonMarchand]

Switching to draft as I asked for a review internally in CDS

[tboch]

Thanks for this PR.
My main comment is about space_sys which I don't like much, and about 'C' which really should be 'sky'.

I see no harm in starting to have a deprecation message for find_datasets.
Should we have a new get_coverage or get_moc method which would be cleaner than the return_moc parameter? This can be added in a later PR of course.

[tboch]

I'm not huge fan of spacesys, but can not find a better one.

[ManonMarchand]

Yes, me neither, I just took the name from the server itself. Maybe @bsipocz or an other maintainer will have a better idea?

[ManonMarchand]

I applied Thomas's suggestions. This is ready to be reviewed 🙂

[bsipocz]

I'll get back to this in the new year. Thanks, Manon and Happy Holidays!