Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

GAIA: Update the information for the returned value in the docstring of the function cross_match. #2937

Merged
merged 1 commit into from
Jan 30, 2024

Conversation

cosmoJFH
Copy link
Contributor

@cosmoJFH cosmoJFH commented Jan 29, 2024

We would like to update the docstring of the function cross_match. The description of the returned value

Boolean indicating if the specified user is valid

should be changed to

A Job object

cc @esdc-esac-esa-int

…o correct typos in the docstring of the function get_datalinks
@cosmoJFH cosmoJFH changed the title Update return value in the docstring of the function cross_match. Update the information for the returned value in the docstring of the function cross_match. Jan 29, 2024
@cosmoJFH cosmoJFH changed the title Update the information for the returned value in the docstring of the function cross_match. GAIA: Update the information for the returned value in the docstring of the function cross_match. Jan 29, 2024
Copy link
Member

@bsipocz bsipocz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'll go ahead and remove the changelog changes and merge the PR. thanks!

CHANGES.rst Outdated
@@ -49,6 +49,8 @@ gaia

- The method ``get_datalinks`` can be used with the new parameter linking_parameter. It completes PR #2859. [#2936]

- Update the docstring for the returned value of the method ``cross_match``. [#2937]
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

no need for changelog for docs related changes. (the need for documenting changelog howto has already raised, so I'll try to write it up sometimes soon.)

astropy/pyvo#516

@bsipocz bsipocz added this to the v0.4.7 milestone Jan 30, 2024
@bsipocz bsipocz force-pushed the ESA_gaia_update_docstring branch from bf6b17c to b4c1492 Compare January 30, 2024 22:07
@bsipocz bsipocz merged commit b39ef34 into astropy:main Jan 30, 2024
9 of 15 checks passed
@bsipocz
Copy link
Member

bsipocz commented Jan 30, 2024

Thanks @cosmoJFH!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants